added support for weekly aggregates with period origin#26
Open
Gauravshah wants to merge 3 commits intomasterfrom
Open
added support for weekly aggregates with period origin#26Gauravshah wants to merge 3 commits intomasterfrom
Gauravshah wants to merge 3 commits intomasterfrom
Conversation
src/partials/config.html
Outdated
| <div class="gf-form max-width-70"> | ||
| <span class="gf-form-label">Period Origin</span> | ||
| <div class="gf-form-select-wrapper gf-form-select-wrapper--has-help-icon max-width-50"> | ||
| <input type="text" class="gf-form-input" ng-model="ctrl.current.jsonData.periodOrigin" spellcheck='false' /> |
There was a problem hiding this comment.
would it be better to have a drop down with possible values ? or text field with placeholder
src/partials/config.html
Outdated
| </div> | ||
| <div class="gf-form max-width-70"> | ||
| <span class="gf-form-label">Period Origin</span> | ||
| <div class="gf-form-select-wrapper gf-form-select-wrapper--has-help-icon max-width-50"> |
There was a problem hiding this comment.
gf-form-select-wrapper class can be replaced as gf-form-input width-20 gf-form-input--has-help-icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly aggregate is now possible with a custom origin
this enables week to start at Monday
druid doc : https://druid.apache.org/docs/latest/querying/granularities.html