Skip to content

Enhance Windows compatibility and improve CMake configurations#190

Open
nblog wants to merge 3 commits intoGopherSecurity:mainfrom
nblog:feature/msvc-build
Open

Enhance Windows compatibility and improve CMake configurations#190
nblog wants to merge 3 commits intoGopherSecurity:mainfrom
nblog:feature/msvc-build

Conversation

@nblog
Copy link

@nblog nblog commented Feb 5, 2026

  • Adjust MSVC compiler options and add definitions for better compatibility.
  • Modify CMakeLists to set appropriate output names for static libraries on Windows.
  • Update logging and network handling for improved signal management and data availability checks.
  • Introduce vcpkg.json for dependency management.

Compiled successfully under VS2026.

- Adjust MSVC compiler options and add definitions for better compatibility.
- Modify CMakeLists to set appropriate output names for static libraries on Windows.
- Update logging and network handling for improved signal management and data availability checks.
- Introduce vcpkg.json for dependency management.
@gophergogo
Copy link
Collaborator

@nblog thanks a lot for the PR, we will be reviewing after #185 and #189

@gophergogo
Copy link
Collaborator

@nblog could you please address merge conflict? then we will review. ~thanks.

@nblog
Copy link
Author

nblog commented Feb 20, 2026

@gophergogo
The current point of contention lies solely in #define getpid _getpid, I believe my approach is preferable since it minimizes or avoids macros, and pid_t is not defined in msvc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants