Skip to content

Conversation

@Skamt
Copy link

@Skamt Skamt commented Dec 14, 2023

turns out when the renderer process crashes nothing happens and it stays running in the background, as OA is missing exception handling around the renderer like in stock discord.

@CanadaHonk
Copy link
Contributor

This shouldn't use try catch, instead use process on uncaught exception/etc

@Skamt
Copy link
Author

Skamt commented Jan 28, 2024

without the renderer's dedicated try catch, if something breaks early the update's try catch catches it and discord gets stuck in the splash checking for updates.
it would require a lot more changes to remedy this, and i try to keep my PR as small as possible, if you think this change is no good, you can close the PR no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants