Skip to content

Conversation

@wesalvaro
Copy link
Member

This dumps a lot of code with no trade-off (hopefully).

It also loads the material chart libraries! yay

The only issue right now is that imageURIs are currently broken.

@wesalvaro
Copy link
Member Author

R: @ebidel
This PR is currently just a preview. It's not ready for a proper review.

@joekarasek
Copy link

I had issues getting google charts to load/render correctly on Safari and Firefox when the bower dependency was passed through gulp-vulcanize (I'm building a polymer app). My understanding (and I'm a junior developer) is that the polyfill for web components caused a race situation: google was 'undefined'. I patched the problem by adding an additional CDN call for google charts loader to the head of the page, but am now getting a warning about multiple calls for google loader.

It would be great if your wrapper took care of this problem. I have not had the same issue with other google web components.

@wesalvaro
Copy link
Member Author

Yes, this is an issue specific to the visualization libraries. It's being worked on, but is not ready yet.

Sorry for the inconvenience, I'd love to see it fixed, too.

@wesalvaro
Copy link
Member Author

@joekarasek Do you still have the same issue with the latest version (1.1.0) of the element?

@rslawik
Copy link
Contributor

rslawik commented Sep 20, 2019

Migrated to ChartWrapper in #250.

@rslawik rslawik closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants