Upgrade Go version to 1.26.3#10081
Open
alphanota wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Go version in go.mod from 1.25.5 to 1.26.3. Feedback indicates that the upgrade is incomplete, highlighting the need to update the vendor directory, GitHub Actions workflows, and Dockerfiles, as well as running go mod tidy to ensure consistency across the project.
| module github.com/GoogleContainerTools/skaffold/v2 | ||
|
|
||
| go 1.25.5 | ||
| go 1.26.3 |
Contributor
There was a problem hiding this comment.
The upgrade to Go 1.26.3 appears incomplete and will likely cause build failures or inconsistencies:
- Vendoring: The project uses vendoring (see
Makefilelines 80 and 101). You must rungo mod vendorto update thevendor/directory. The Go toolchain requiresvendor/modules.txtto match thegodirective ingo.modwhen building with-mod=vendor. - Missing Workflow Updates: The PR description mentions upgrading GitHub Actions workflows, but no changes to
.github/workflows/are included in the diff. - Dockerfile Consistency: Dockerfiles (e.g.,
deploy/skaffold/Dockerfile) should be updated to use the1.26.3base image to ensure consistency between development and build environments. - Checksums and Tidying: Ensure
go.sumis updated and rungo mod tidyto refresh dependency annotations for the new toolchain version.
alphanota
force-pushed
the
upgrade-go-1.26.3
branch
from
e966302 to
3238948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Go version to 1.26.3 to address security vulnerabilities in the Go standard library. This upgrades the go.mod directive and the GitHub Actions workflows to use Go 1.26.3.