feat: validate actions for merged-usr violations#1912
Conversation
Summary of ChangesHello @thesayyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a crucial validation step for OCI images built using Bazel, specifically targeting Debian 13. By integrating a new Bazel aspect, it automatically checks for violations of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a Bazel aspect to validate merged-usr compliance for debian13 targets, which is a valuable addition for ensuring the correctness of the built container images. The implementation is generally sound, but I've identified a critical issue in the validation logic that would lead to incorrect failures on valid images. Additionally, I've provided several suggestions to enhance the maintainability and extensibility of the new validation aspect.
|
🌳 🔄 Image Check |
d9c6e07 to
a3bf482
Compare
a3bf482 to
9a6cc56
Compare
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
9a6cc56 to
b620b53
Compare
5869d39 to
022f61b
Compare
loosebazooka
left a comment
There was a problem hiding this comment.
so something I didn't realize is this was only checking ./, instead of all the root specification mechanisms
Creates bazel validation actions for the debian13 targets to ensure that no layer violates the
merged-usrconventions. This ensures both upstream debian packages and intermediate layers created by both distroless and rules_distroless is mergedusr compliant.