This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Domain from request#149
Open
Mark-Hetherington wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Open
Domain from request#149Mark-Hetherington wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Mark-Hetherington wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
added 3 commits
September 17, 2019 16:46
Otherwise we get a repr style <str>'b\'<content>\''
On paste.httpserver SERVER_NAME is 127.0.0.1, on waitress SERVER_NAME is local machine name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "SERVER_NAME" environment variable seems to be set to an IP address in several environments (paste.httpserver, waitress.serve). But it seems request.domain is set in webob.Request, based on request.host, which preferences environ['HTTP_HOST'] over environ['SERVER_NAME'].