This repository was archived by the owner on Nov 30, 2023. It is now read-only.
fix module init issues caused by import cycle#144
Open
zevdg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
fix module init issues caused by import cycle#144zevdg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
zevdg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
webapp and webapp2 import eachother. Currently if they aren't imported in the correct order, they wouldn't initiaze properly. By deferring all of the webapp imports in webapp2 until after initialization has finished, we sidestep the problem.
Author
|
is this project still accepting PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webapp and webapp2 import eachother. Currently if they aren't imported in the
correct order, they wouldn't initiaze properly. By deferring all of the
webapp imports in webapp2 until after initialization has finished, we sidestep
the problem.