This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Successful build with recent gcp-devrel-py-tools, flake8, App Engine SDK#142
Open
AniX wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
Open
Successful build with recent gcp-devrel-py-tools, flake8, App Engine SDK#142AniX wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
AniX wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
Conversation
added 6 commits
November 5, 2018 21:34
reason: travis build environment upgraded pip from 6.0.7 to 9.0.1, which is incompatible with gcp-devrel-py-tools 0.0.8; otherwise build-job `tests_gaesdk` would keep failing with `ImportError`
…cent flake8 versions - add .flake8, ignore must also include (replaced) default-ignore, and a few of them are mutually exclusive - ignore class I, for import rules that are in conflict with Google Python Style Guide - reformatting some places in code to avoid errors - not yet addressed: W605 invalid escape sequence '\d'
…cent flake8 versions - address W504 line break after binary operator and E501 line too long - not yet addressed: W605 invalid escape sequence '\d'
…cent flake8 versions resolve `W605 invalid escape sequence '\x'`, see https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior flake8 3.6.0 produces W605 in docstrings that are not raw-string
It seems that somewhere between 1.9.54 and 1.9.66, App Engine SDK removed support of webapp1, probably because support of Python 2.5 also had been removed from App Engine Python standard environment. As a result, the behavior with using old style request handlers changed, and so two tests in webapp1_test.py would fail. Resolution: Replace tests regarding old WSGIApplication and/or old RequestHandler. All gaesdk tests use WSGIApplication and RequestHandler of webapp2. Asserts reflect behavior of webapp2 app and handler.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
========================================
- Coverage 95.81% 94.82% -1%
========================================
Files 17 16 -1
Lines 1818 1604 -214
Branches 274 252 -22
========================================
- Hits 1742 1521 -221
- Misses 19 33 +14
+ Partials 57 50 -7
Continue to review full report at Codecov.
|
Author
|
Sorry, didn't foresee impact on codecov. Decline in test coverage probably caused by replacing old WSGIApplication and old RequestHandler in gaesdk tests, basically replaced webapp1 tests by webapp2 tests. What would be the best course of action here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve failing builds for old code-base as reported in #139 and #140.
#140: upgrade gcp-devrel-py-tools to 0.0.15
reason: travis build environment upgraded pip from 6.0.7 to 9.0.1,
which is incompatible with gcp-devrel-py-tools 0.0.8; otherwise
build-job
tests_gaesdkwould keep failing withImportError#140: Replace webapp1 tests by webapp2 tests
It seems that somewhere between 1.9.54 and 1.9.66, App Engine SDK
removed support of webapp1, probably because support of Python 2.5 also
had been removed from App Engine Python standard environment. As a
result, the behavior with using old style request handlers changed, and
so two tests in webapp1_test.py would fail.
Resolution: Replace tests regarding old WSGIApplication and/or old
RequestHandler. All gaesdk tests use WSGIApplication and RequestHandler
of webapp2. Asserts reflect behavior of webapp2 app and handler.
#139: resolve lint errors after changes in more recent flake8 versions
W605 invalid escape sequence '\x', seehttps://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior