fix(hub): support GITHUB_TOKEN secret fallback for remote template imports#260
Open
chiefkarlin wants to merge 1 commit into
Open
fix(hub): support GITHUB_TOKEN secret fallback for remote template imports#260chiefkarlin wants to merge 1 commit into
chiefkarlin wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism to retrieve a project's GITHUB_TOKEN from either the secret backend or the database when importing templates from a remote source, and adds a corresponding unit test. The feedback recommends using the server's dedicated templateLog instead of the global slog for consistency, and addresses potential data races and test flakiness in the new unit test by protecting shared state with a mutex and restricting the mocked HTTP transport.
b1eab0c to
e524c8b
Compare
e524c8b to
19b0d19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an authentication failure when importing remote templates from private GitHub repositories.
Changes
GITHUB_TOKENfrom the secret backend (or database fallback) inpkg/hub/template_bootstrap.go.FetchRemoteTemplateto authenticate download and git operations.TestImportTemplatesFromRemote_WithProjectGithubTokento verify the secret resolution and fallback path using a mock HTTP client.Closes #258