add directory to opencode system-prompt/instructions writing#208
Open
verdverm wants to merge 2 commits into
Open
add directory to opencode system-prompt/instructions writing#208verdverm wants to merge 2 commits into
verdverm wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the file path for AGENTS.md in the OpenCode harness to be located within a .config/opencode subdirectory. Review feedback points out that the os.WriteFile calls will fail if the new directory structure does not already exist and recommends using os.MkdirAll to create the path, while also suggesting the use of a helper method to avoid hardcoding the configuration directory name.
7d00999 to
2eaa28e
Compare
2eaa28e to
81814b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the file location consistent with other harnesses, was not being picked up by
opencodebecause it ended up in$HOMEinstead of$HOME/.config/opencode