Add OTLP client certificate support#139
Draft
mfreeman451 wants to merge 2 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for OTLP mTLS by introducing client certificate and key configuration options across the telemetry and logging packages. It refactors TLS loading into a centralized utility and updates environment variable handling. Feedback suggests hardening the TLS configuration by explicitly requiring a minimum version of TLS 1.2.
| var errOTLPMissingClientKeyPair = errors.New("OTLP client certificate and key must be provided together") | ||
|
|
||
| func LoadOTLPTLSConfig(caFile, certFile, keyFile string) (*tls.Config, error) { | ||
| tlsConfig := &tls.Config{} |
Contributor
There was a problem hiding this comment.
For better security, it is recommended to explicitly set the minimum TLS version to 1.2. This ensures that the client does not negotiate older, less secure versions of TLS, which is a best practice for modern OTLP communication.
tlsConfig := &tls.Config{
MinVersion: tls.VersionTLS12,
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This was part of the known-good Kubernetes integration stack. It fixes the mTLS client-auth gap for OTLP exporters so hosted agents can connect to an OTLP endpoint that requires client certificates.
Validation
go test ./pkg/sciontool/telemetry ./pkg/util/logging -count=1