Add when argument to archive_pattern directive#1647
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for conditional archiving using when directives in Ramble. It updates the archive_pattern directive to accept a when parameter, structures the stored patterns by their conditions, and updates both the pipeline execution and the base application class to only archive files when their respective conditions are satisfied. Additionally, tests have been added to verify this behavior.
Feedback is provided regarding an inconsistency in how relative paths are resolved in pipeline.py compared to base_class.py. Specifically, relative patterns in print_archive_files should be resolved against the experiment run directory before calling glob.glob to avoid evaluating them against the current working directory.
Ramble Performance Test MetricsResults produced with commit: fa646b3
|
8be5a44 to
fa646b3
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1647 +/- ##
========================================
Coverage 93.20% 93.20%
========================================
Files 346 346
Lines 33451 33498 +47
========================================
+ Hits 31179 31223 +44
- Misses 2272 2275 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.