Fix potential deadlock in tty.log writer_daemon [AI]

[douglasjacobsen]

When use_fds falls back to False (which occurs when pytest replaces standard file descriptors with its StringIO streams for capture via capsys ), sys.stdout was not being correctly closed upon context exit. This caused the pipe to leak and the main process to wait indefinitely on the daemon to exit.

[gemini-code-assist]

Code Review

This pull request updates the log utility to close sys.stdout when exiting the context. The review feedback suggests wrapping the restoration of sys.stdout and sys.stderr in a finally block to guarantee they are restored even if a BaseException (such as KeyboardInterrupt) is raised during the close operation.

[ramble-pr-bot]

Ramble Performance Test Metrics

Results produced with commit: 28aeded

Test Name	Outcome	Duration (s)	Most Recent Run (s)	Last 5 Avg (s)
test_analyze_large_file	passed	2.9266	2.8945 (8f5d773)	2.9626
test_large_template_expansion	passed	2.1183	2.1238 (8f5d773)	2.1349
test_many_experiments	passed	33.0157	35.7788 (8f5d773)	35.0693
test_many_objects_defaults	passed	18.4714	19.2193 (8f5d773)	19.2297
test_matrix_filter_perf	passed	1.5979	1.5927 (8f5d773)	1.6091

[douglasjacobsen]

/gemini review

[gemini-code-assist]

Code Review

This pull request modifies the exit method in lib/ramble/llnl/util/tty/log.py to attempt to close sys.stdout before restoring the saved stdout and stderr streams. The reviewer recommended extending this to close both sys.stdout and sys.stderr to avoid potential pipe leaks and deadlocks if sys.stdout was reassigned during the block.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (6f2bd59) to head (28aeded).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1639   +/-   ##
========================================
  Coverage    93.20%   93.20%           
========================================
  Files          346      346           
  Lines        33451    33451           
========================================
  Hits         31179    31179           
  Misses        2272     2272           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[linsword13]

Thanks for the fix. Personally I prefer the wholesale update from #1644 over this patch.