chore(gemma2/dataflow): update google-cloud-aiplatform and protobuf for gemma2#14350
Conversation
…for gemma2 - Update `google-cloud-aiplatform` to 1.158.0 in `gemma2/` and `dataflow/` samples - Update `protobuf` to 6.33.6 in `gemma2/` - Remove python version constraint for pytest in `gemma2/`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies across several requirements files, upgrading google-cloud-aiplatform to version 1.158.0 and updating protobuf and pytest versions. Feedback on the changes suggests retaining the [full] extra for google-cloud-aiplatform in gemma2/requirements.txt to prevent potential runtime ImportErrors from missing dependencies.
| @@ -1,2 +1,2 @@ | |||
| google-cloud-aiplatform[full]==1.157.0 | |||
| protobuf==5.29.5 | |||
| google-cloud-aiplatform==1.158.0 | |||
There was a problem hiding this comment.
The [full] extra was removed from google-cloud-aiplatform during this upgrade. If the gemma2 sample relies on any of the extra dependencies installed by google-cloud-aiplatform[full] (such as tensorboard, shap, etc.), this could cause runtime ImportErrors. Please retain the [full] extra.
google-cloud-aiplatform[full]==1.158.0
There was a problem hiding this comment.
I tested this changes witouth the full, and found it to not be necessary, on the contrary, using the full caused issued on installation.
|
I have tested this dependency changes on Python 3.10 and 3.14, both are working correctly. Please note that python 3.10 has a few warnings about that specific version being phased out: 
|
4 participants
Description
google-cloud-aiplatformto 1.158.0 ingemma2/anddataflow/samplesprotobufto 6.33.6 ingemma2/gemma2/Fixes b/8400024
Checklist
Testing
Compliance & Style
Post-Approval Actions