feat(storage): support delete source objects on compose#14349
Open
nidhiii-27 wants to merge 2 commits into
Open
feat(storage): support delete source objects on compose#14349nidhiii-27 wants to merge 2 commits into
nidhiii-27 wants to merge 2 commits into
Conversation
Add deleteSourceObjects parameter to compose sample. Updated test to assert both delete behavior scenarios. [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the "delete_source_objects" parameter in the "compose_file" snippet, enabling the deletion of source objects after composition, and includes unit tests to verify both the default and deletion behaviors. The reviewer suggested refactoring the conditional print statements in "storage_compose_file.py" to use a conditional suffix string, which reduces code duplication and improves maintainability.
Comment on lines
60
to
71
| if delete_source_objects: | ||
| print( | ||
| "New composite object {} in the bucket {} was created by combining {} and {}. Source objects were deleted.".format( | ||
| destination_blob_name, bucket_name, first_blob_name, second_blob_name | ||
| ) | ||
| ) | ||
| else: | ||
| print( | ||
| "New composite object {} in the bucket {} was created by combining {} and {}".format( | ||
| destination_blob_name, bucket_name, first_blob_name, second_blob_name | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
The print statements for when delete_source_objects is True vs False are highly duplicated. We can simplify this by using a conditional suffix string, which reduces duplication and improves maintainability.
suffix = " Source objects were deleted." if delete_source_objects else ""
print(
"New composite object {} in the bucket {} was created by combining {} and {}.{}".format(
destination_blob_name, bucket_name, first_blob_name, second_blob_name, suffix
)
)- Reordered imports in snippets_test.py to satisfy flake8. - Refactored storage_compose_file.py print statements to avoid duplication. [Generated-by: AI]
product-auto-label
Bot
added
api: storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates compose file sample to support deleting source objects optionally. Fixes b/441557254