Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataflow/gemma-flex-template/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN pip install --no-cache-dir --upgrade pip \
# Copy SDK entrypoint binary from Apache Beam image, which makes it possible to
# use the image as SDK container image.
# The Beam version should match the version specified in requirements.txt
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Beam SDK version in the Docker FROM instruction (2.69.0) does not match the apache_beam version in dataflow/gemma-flex-template/requirements.txt (2.66.0). As noted in the comment on line 32, these versions should match to avoid runtime issues. Please update the apache_beam version in requirements.txt to 2.69.0.


# Copy Flex Template launcher binary from the launcher image, which makes it
# possible to use the image as a Flex Template base image.
Expand Down
2 changes: 1 addition & 1 deletion dataflow/gpu-examples/pytorch-minimal/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ RUN pip install --no-cache-dir --upgrade pip \
&& pip check

# Set the entrypoint to Apache Beam SDK worker launcher.
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a version mismatch between the Beam SDK version (2.69.0) and the apache-beam version in dataflow/gpu-examples/pytorch-minimal/requirements.txt (2.48.0). Using mismatched versions can lead to runtime errors. Please update the apache-beam version in requirements.txt to 2.69.0.

ENTRYPOINT [ "/opt/apache/beam/boot" ]
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ RUN apt-get update \

# Set the entrypoint to Apache Beam SDK worker launcher.
# Check this matches the apache-beam version in the requirements.txt
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Beam SDK version (2.69.0) does not match the apache-beam version in dataflow/gpu-examples/tensorflow-landsat-prime/requirements.txt (2.58.1). As the comment on line 37 suggests, these versions should match. Please update the apache-beam version in requirements.txt to 2.69.0 to ensure compatibility.

ENTRYPOINT [ "/opt/apache/beam/boot" ]
2 changes: 1 addition & 1 deletion dataflow/gpu-examples/tensorflow-landsat/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ RUN apt-get update \

# Set the entrypoint to Apache Beam SDK worker launcher.
# Check this matches the apache-beam version in the requirements.txt
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a version mismatch. The Beam SDK version is updated to 2.69.0, but the apache-beam version in dataflow/gpu-examples/tensorflow-landsat/requirements.txt is still 2.58.1. To prevent potential runtime issues, please update the apache-beam version in requirements.txt to 2.69.0.

ENTRYPOINT [ "/opt/apache/beam/boot" ]
2 changes: 1 addition & 1 deletion dataflow/gpu-examples/tensorflow-minimal/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ RUN apt-get update \

# Set the entrypoint to Apache Beam SDK worker launcher.
# Check this matches the apache-beam version in the requirements.txt
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Beam SDK version has been updated to 2.69.0, but the apache-beam version in dataflow/gpu-examples/tensorflow-minimal/requirements.txt remains 2.46.0. This significant version difference can cause issues. Please update the apache-beam version in requirements.txt to 2.69.0.

ENTRYPOINT [ "/opt/apache/beam/boot" ]
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ RUN pip install --no-cache-dir --upgrade pip \

# Set the entrypoint to Apache Beam SDK worker launcher.
# Check this matches the apache-beam version in the requirements.txt
COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Beam SDK version is now 2.69.0, but the apache-beam version in people-and-planet-ai/timeseries-classification/requirements.txt is 2.46.0. As the comment on line 27 indicates, these versions should match. Please update the apache-beam version in requirements.txt to 2.69.0.

ENTRYPOINT [ "/opt/apache/beam/boot" ]