Skip to content

OperatorConfig CEL Validation#1957

Draft
bernot-dev wants to merge 1 commit into
mainfrom
operatorconfig-cel-validation
Draft

OperatorConfig CEL Validation#1957
bernot-dev wants to merge 1 commit into
mainfrom
operatorconfig-cel-validation

Conversation

@bernot-dev

@bernot-dev bernot-dev commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Adds kubebuilder CEL validations to OperatorConfig fields based on the migration away from webhook validation.

  • Validates prometheus label keys in externalLabels
  • Validates queryProjectID constraints (length and regex pattern)
  • Adds isURL checks for generatorUrl, exports.url, externalURL
  • Implements RFC 1123 label constraints for AlertmanagerEndpoints namespace and name
  • Validates TLSConfig KeySecret name
  • Enforces HTTP/HTTPS scheme for AlertmanagerEndpoints

@bernot-dev bernot-dev force-pushed the operatorconfig-cel-validation branch from 95ec286 to 86a9805 Compare June 12, 2026 14:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces various OpenAPI and CEL validation constraints to the OperatorConfig CRD definitions and adds corresponding end-to-end validation tests. The reviewer identified several critical issues: the use of the non-existent CEL function isURL which will cause CRD application failures, and a MinLength constraint on queryProjectID that incorrectly prevents it from being left blank. Additionally, the reviewer noted a duplicate import of k8s.io/api/core/v1 under different aliases in the test file, recommending the consistent use of the existing v1 alias.

Comment thread pkg/operator/apis/monitoring/v1/operator_types.go
Comment thread pkg/operator/apis/monitoring/v1/operator_types.go
Comment thread pkg/operator/apis/monitoring/v1/operator_types.go
Comment thread charts/operator/crds/monitoring.googleapis.com_operatorconfigs.yaml
Comment thread charts/operator/crds/monitoring.googleapis.com_operatorconfigs.yaml
Comment thread charts/operator/crds/monitoring.googleapis.com_operatorconfigs.yaml
Comment thread pkg/operator/apis/monitoring/v1/operator_types.go Outdated
Comment thread charts/operator/crds/monitoring.googleapis.com_operatorconfigs.yaml Outdated
Comment thread e2e/crd_validation_test.go Outdated
Comment thread e2e/crd_validation_test.go
@bernot-dev bernot-dev force-pushed the operatorconfig-cel-validation branch 2 times, most recently from 50f73ff to 314c2bd Compare June 15, 2026 17:57
@bernot-dev

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces declarative CEL validations and kubebuilder constraints to OperatorConfig CRD fields, ensuring stricter validation for URLs, GCP project IDs, external labels, and secret names directly at the API level. Corresponding end-to-end tests were updated to clean up test resources and verify these new validation rules. The review feedback suggests further strengthening the validations by enforcing mutual exclusivity between the secret and configMap fields in SecretOrConfigMap, as well as adding DNS subdomain validation for the configMap name.

Comment thread pkg/operator/apis/monitoring/v1/operator_types.go
Comment thread pkg/operator/apis/monitoring/v1/operator_types.go
@bernot-dev bernot-dev force-pushed the operatorconfig-cel-validation branch from 314c2bd to 9c4ddb7 Compare June 15, 2026 18:42
Adds kubebuilder CEL validations to `OperatorConfig` fields based on the migration away from webhook validation.

- Validates prometheus label keys in `externalLabels`
- Validates `queryProjectID` constraints (length and regex pattern)
- Adds `isURL` checks for `generatorUrl`, `exports.url`, `externalURL`
- Implements RFC 1123 label constraints for AlertmanagerEndpoints namespace and name
- Validates TLSConfig KeySecret name
- Enforces HTTP/HTTPS scheme for AlertmanagerEndpoints

Signed-off-by: Adam Bernot <bernot@google.com>
@bernot-dev bernot-dev force-pushed the operatorconfig-cel-validation branch from 9c4ddb7 to 12de88d Compare June 15, 2026 18:49
@bernot-dev bernot-dev self-assigned this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant