Open
Conversation
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
| @@ -58,6 +61,7 @@ def do_connect( | |||
Collaborator
There was a problem hiding this comment.
I think it is a bad idea for us to set the default value for this port - this is true for all dbs. The underlying driver sets the default port, so we don't have to. If there is every a change in the default in the future, you need to update this.
Collaborator
Author
There was a problem hiding this comment.
That's not actually a line I changed. Although I did copy that line into the z/OS version of the same method.
I've removed the port default from both implementations.
Collaborator
|
LGTM. Unfortunately, we can't test these change nightly. |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
|
/gcbrun |
sundar-mudupalli-work
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds support for Db2 z/OS and makes the distinction that our existing support was for Db2 LUW.
In the most part Db2 z/OS shares code with LUW. We've added a new Backend because there are some differences, but not a huge amount. The underlying ibm_db/ibm_db_sa drivers are used for both.
Notable differences:
db2_generated_docid_for_xmlanddb2_generated_rowid_for_lob. We added code to exclude these from the Ibis tables because we could not influence the SQL used by the driver.coalesce.As a side task I moved some Impala/Hive code out of
operations.pyinto dedicated files.Unfortunately we have no access to a Db2 z/OS test system. For the most part I've been able to rely on testing code using LUW. I have also benefited from Db2 z/OS testing by the customer who requested this work.
Issues to be closed
Closes #1630
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)