fix: Modify BQ connection to use the correct project id for billing.#1715
Merged
sundar-mudupalli-work merged 11 commits intodevelopfrom Apr 18, 2026
Merged
fix: Modify BQ connection to use the correct project id for billing.#1715sundar-mudupalli-work merged 11 commits intodevelopfrom
sundar-mudupalli-work merged 11 commits intodevelopfrom
Conversation
sundar-mudupalli-work
force-pushed
the
issue-1710
branch
from
3609cbb to
a463e5e
Compare
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
6 tasks
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
nj1973
reviewed
Apr 1, 2026
Collaborator
Author
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
nj1973
requested changes
Apr 14, 2026
Collaborator
|
/gcbrun |
nj1973
approved these changes
Apr 15, 2026
Collaborator
nj1973
left a comment
nj1973
left a comment
There was a problem hiding this comment.
LGTM. I did remove the line I requested you to remove from the storage API client so please review that before clicking merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As outlined in issue 1710, DVT forces the billing project resulting in incorrect (or non standard) behavior. This fix modifies the way DVT creates the BQ client, so that it behaves like other client libraries/programs. Additionally
--billing-project-idfor clarity--client-project-id- users who use it will receive a warning and it will be accepted.Issues to be closed
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Closes #1710
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)