New data sources: google_discovery_engine_data_store(s)#16637
New data sources: google_discovery_engine_data_store(s)#16637mahdilamb wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
ed246f2 to
f757f26
Compare
Add two handwritten data sources for Discovery Engine data stores: - `google_discovery_engine_data_store`: retrieves a single data store by `data_store_id` or `display_name` (mutually exclusive). Errors if multiple stores share the same display name. - `google_discovery_engine_data_stores`: lists all data stores in a project/location with pagination support. Both default `location` to "global" and inherit `project` from the provider config when not specified. The singular data source reuses the existing resource's flatten helpers.
f757f26 to
07d4218
Compare
Wrote this using Claude to add discoveryengine datastores. Tried to follow the style of google_storage_bucket(s), but to cover a few more use cases. I have reviewed the generated code myself.
Fixes hashicorp/terraform-provider-google#26375
Add two new handwritten data sources for Discovery Engine data stores:
google_discovery_engine_data_store(singular) — Look up a single data store bydata_store_idordisplay_name. When looking up by display name, lists all stores and returns an error if zero or multiple matches are found.google_discovery_engine_data_stores(plural) — List all data stores in a given project and location.Both data sources:
locationto"global"and inheritprojectfrom the provider if not set{{DiscoveryEngineBasePath}}Files added/modified
data_source_discovery_engine_data_store.go— singular data sourcedata_source_discovery_engine_data_stores.go— plural data sourcedata_source_discovery_engine_data_store_test.go— singular acceptance test (by ID + by display_name)data_source_discovery_engine_data_stores_test.go— plural acceptance testdiscovery_engine_data_store.html.markdown— singular docsdiscovery_engine_data_stores.html.markdown— plural docsprovider_mmv1_resources.go.tmpl— register both data sourcesGenerated with Claude Code (Claude Opus 4.6)