Skip to content

Add MetadataFeed support to Dataplex#16631

Open
MingyanZhao wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
MingyanZhao:feature/metadatafeed
Open

Add MetadataFeed support to Dataplex#16631
MingyanZhao wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
MingyanZhao:feature/metadatafeed

Conversation

@MingyanZhao
Copy link

@MingyanZhao MingyanZhao commented Mar 5, 2026

`google_dataplex_metadata_feed`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn March 5, 2026 23:52
base_url: 'projects/{{project}}/locations/{{location}}/metadataFeeds/{{metadata_feed_id}}'
self_link: 'projects/{{project}}/locations/{{location}}/metadataFeeds/{{metadata_feed_id}}'
create_url: 'projects/{{project}}/locations/{{location}}/metadataFeeds?metadataFeedId={{metadata_feed_id}}'
update_verb: 'PATCH'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is updatable, can we add an update test?

@modular-magician modular-magician added service/dataplex and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 6, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1966 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1963 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 634 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_metadata_feed (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_metadata_feed" "primary" {
  filters {
    aspect_types = # value needed
    change_types = # value needed
    entry_types  = # value needed
  }
  labels       = # value needed
  pubsub_topic = # value needed
  scope {
    entry_groups = # value needed
    projects     = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 84
Passed tests: 80
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • dataplex

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexMetadataFeedIamBindingGenerated
  • TestAccDataplexMetadataFeedIamMemberGenerated
  • TestAccDataplexMetadataFeedIamPolicyGenerated
  • TestAccDataplexMetadataFeed_dataplexMetadataFeedBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexMetadataFeedIamBindingGenerated [Error message] [Debug log]
TestAccDataplexMetadataFeedIamMemberGenerated [Error message] [Debug log]
TestAccDataplexMetadataFeedIamPolicyGenerated [Error message] [Debug log]
TestAccDataplexMetadataFeed_dataplexMetadataFeedBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants