Add retry for GCE 403 concurrent operations quota errors#16625
Open
golgeek wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Add retry for GCE 403 concurrent operations quota errors#16625golgeek wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
golgeek wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Signed-off-by: Ludovic Leroux <ludo.leroux@cockroachlabs.com>
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCE returns HTTP 403 (not 429) when the concurrent operations quota is exceeded.
The error includes reason
CONCURRENT_OPERATIONS_QUOTA_EXCEEDEDin the error details.This is a transient condition that clears as soon as in-flight operations complete, but the provider currently treats it as a hard failure.
This adds a new global retry predicate
is403ConcurrentOperationsQuotaErrorthat matches 403 errors withCONCURRENT_OPERATIONS_QUOTA_EXCEEDEDin theErrorInfodetails and retries them automatically.Fixes hashicorp/terraform-provider-google#9207
Release Note Template