Skip to content

Feature Gap: Implement acceleratorTopologyMode for ResourcePolicy#16623

Open
Cezarus27 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Cezarus27:resource_policy_accelerator_topology_mode
Open

Feature Gap: Implement acceleratorTopologyMode for ResourcePolicy#16623
Cezarus27 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Cezarus27:resource_policy_accelerator_topology_mode

Conversation

@Cezarus27
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `workload_policy.0.accelerator_topology_mode` and `group_placement_policy.0.accelerator_topology_mode` fields to `google_compute_resource_policy` resource (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 5, 2026
@github-actions github-actions bot requested a review from BBBmau March 5, 2026 14:22
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com>
@Cezarus27 Cezarus27 force-pushed the resource_policy_accelerator_topology_mode branch from 8be794a to b41894f Compare March 5, 2026 14:43
@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 5, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 160 insertions(+))
google-beta provider: Diff ( 4 files changed, 212 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 28 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field group_placement_policy.accelerator_topology_mode added as optional with a default value and force new on pre-existing resource google_compute_resource_policy. This can be allowed if there is a confirmed API-level default that matches the schema default - reference
  • Field workload_policy.accelerator_topology_mode added as optional with a default value and force new on pre-existing resource google_compute_resource_policy. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resource_policy (51 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resource_policy" "primary" {
  group_placement_policy {
    accelerator_topology_mode = # value needed
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants