Skip to content

tgc-revival: Fix retry logic in assert_test_files.go#16617

Draft
zli82016 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
zli82016:fix-retry-logic-tgc-next
Draft

tgc-revival: Fix retry logic in assert_test_files.go#16617
zli82016 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
zli82016:fix-retry-logic-tgc-next

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Mar 4, 2026

Modify the retry logic in
mmv1/third_party/tgc_next/test/assert_test_files.go
to ensure that tests are skipped only if all attempts failed due to "test data is unavailable". Currently, it skips if the last error was "test data is unavailable", which might be incorrect if previous attempts failed for other reasons.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+), 12 deletions(-))

@zli82016 zli82016 force-pushed the fix-retry-logic-tgc-next branch from 45df7f7 to 140ef7b Compare March 5, 2026 01:07
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 2 files changed, 24 insertions(+), 12 deletions(-))

@zli82016 zli82016 force-pushed the fix-retry-logic-tgc-next branch from 140ef7b to 3ab8094 Compare March 6, 2026 23:00
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 2 files changed, 24 insertions(+), 12 deletions(-))

@zli82016 zli82016 force-pushed the fix-retry-logic-tgc-next branch from af7286e to 5a08328 Compare March 7, 2026 00:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 28 insertions(+), 15 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants