Skip to content

Feature gap: Implement targetSizePolicy.mode to InstanceGroupManager#16615

Open
Cezarus27 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Cezarus27:igm_beta_target_size_policy
Open

Feature gap: Implement targetSizePolicy.mode to InstanceGroupManager#16615
Cezarus27 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Cezarus27:igm_beta_target_size_policy

Conversation

@Cezarus27
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `target_size_policy.0.mode` field to `google_compute_instance_group_manager` resource (beta)

Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com>
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 4, 2026
@github-actions github-actions bot requested a review from ScottSuarez March 4, 2026 19:15
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing to compile

--- see failing check

@Cezarus27
Copy link
Contributor Author

failing to compile

--- see failing check

Project which runs tests needs to be added to allow list to be able to set target_size_policy.0.mode on creation. Update of this field is not available yet.

@github-actions github-actions bot requested a review from ScottSuarez March 6, 2026 08:47
@ScottSuarez
Copy link
Contributor

Well the issue is the library doesn't have the method mentioned

Error: google/services/compute/resource_compute_instance_group_manager.go:1295:64: undefined: compute.InstanceGroupManagerTargetSizePolicy
Error: google/services/compute/resource_compute_instance_group_manager.go:1300:18: undefined: compute.InstanceGroupManagerTargetSizePolicy
Error: google/services/compute/resource_compute_instance_group_manager.go:1637:56: undefined: compute.InstanceGroupManagerTargetSizePolicy

which is likely due to the field being unreleased. This library we use is generated from the discovery docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants