Add Terraform support for Chronicle Data Table resource#16607
Add Terraform support for Chronicle Data Table resource#16607harshita298 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
8ac14da to
2bec549
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
column_info {
key_column = # value needed
mapped_column_path = # value needed
repeated_values = # value needed
}
deletion_policy = # value needed
scope_info {
data_access_scopes = # value needed
}
update_source = # value needed
}
|
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
column_info {
key_column = # value needed
mapped_column_path = # value needed
repeated_values = # value needed
}
deletion_policy = # value needed
scope_info {
data_access_scopes = # value needed
}
update_source = # value needed
}
|
Tests analyticsTotal tests: 24 Click here to see the affected service packages
🟢 All tests passed! View the build log |
2bec549 to
4390739
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
column_info {
key_column = # value needed
mapped_column_path = # value needed
repeated_values = # value needed
}
deletion_policy = # value needed
scope_info {
data_access_scopes = # value needed
}
update_source = # value needed
}
|
Tests analyticsTotal tests: 24 Click here to see the affected service packages
🟢 All tests passed! View the build log |
mmv1/third_party/terraform/services/chronicle/resource_chronicle_data_table_test.go
Outdated
Show resolved
Hide resolved
4390739 to
5751880
Compare
5751880 to
b702df5
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
deletion_policy = # value needed
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
deletion_policy = # value needed
}
|
Tests analyticsTotal tests: 25 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 25 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| type: Array | ||
| description: |- | ||
| Contains the list of scope names of the data table. If the list is empty, | ||
| the data table is treated as unscoped. The scope names should be |
There was a problem hiding this comment.
Creating a separate comment as unable to unresolved: Would be great if you can test it once and confirm.
There was a problem hiding this comment.
I have checked this by local testing. If we send the empty list in data access scope, unscoped table is created.
b702df5 to
915c14e
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
deletion_policy = # value needed
}
|
Tests analyticsTotal tests: 25 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
915c14e to
86e0142
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_data_table" "primary" {
deletion_policy = # value needed
}
|
Tests analyticsTotal tests: 25 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
This PR introduces Terraform support for the Chronicle Data Table resource by adding the
google_chronicle_datatableresource.This includes:
Related Issue
Fixes hashicorp/terraform-provider-google#26326
Release Note Template for Downstream PRs (will be copied)