Skip to content

Add Terraform support for Chronicle Data Table resource#16607

Open
harshita298 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
harshita298:chronicle-datatable-harshiita
Open

Add Terraform support for Chronicle Data Table resource#16607
harshita298 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
harshita298:chronicle-datatable-harshiita

Conversation

@harshita298
Copy link

This PR introduces Terraform support for the Chronicle Data Table resource by adding the google_chronicle_datatable resource.

This includes:

  • Schema definition for the resource.
  • Create and Update functionalities.
  • Acceptance tests to cover the resource lifecycle.

Related Issue
Fixes hashicorp/terraform-provider-google#26326

Release Note Template for Downstream PRs (will be copied)

`google_chronicle_datatable` (beta)

@google-cla
Copy link

google-cla bot commented Mar 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from roaks3 March 4, 2026 15:17
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 401 insertions(+))
google-beta provider: Diff ( 6 files changed, 1529 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  column_info {
    key_column         = # value needed
    mapped_column_path = # value needed
    repeated_values    = # value needed
  }
  deletion_policy = # value needed
  scope_info {
    data_access_scopes = # value needed
  }
  update_source = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 21
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataTable_chronicleDataTableBasicExample
  • TestAccChronicleDataTable_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataTable_chronicleDataTableBasicExample [Debug log]
TestAccChronicleDataTable_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 401 insertions(+))
google-beta provider: Diff ( 6 files changed, 1529 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  column_info {
    key_column         = # value needed
    mapped_column_path = # value needed
    repeated_values    = # value needed
  }
  deletion_policy = # value needed
  scope_info {
    data_access_scopes = # value needed
  }
  update_source = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

@harshita298 harshita298 force-pushed the chronicle-datatable-harshiita branch from 2bec549 to 4390739 Compare March 4, 2026 16:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 401 insertions(+))
google-beta provider: Diff ( 6 files changed, 1529 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  column_info {
    key_column         = # value needed
    mapped_column_path = # value needed
    repeated_values    = # value needed
  }
  deletion_policy = # value needed
  scope_info {
    data_access_scopes = # value needed
  }
  update_source = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

@harshita298 harshita298 force-pushed the chronicle-datatable-harshiita branch from 4390739 to 5751880 Compare March 6, 2026 10:41
@harshita298 harshita298 force-pushed the chronicle-datatable-harshiita branch from 5751880 to b702df5 Compare March 6, 2026 10:46
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 486 insertions(+))
google-beta provider: Diff ( 6 files changed, 1705 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 486 insertions(+))
google-beta provider: Diff ( 6 files changed, 1705 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 22
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample
  • TestAccChronicleDataTable_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample [Error message] [Debug log]
TestAccChronicleDataTable_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 22
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample
  • TestAccChronicleDataTable_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample [Error message] [Debug log]
TestAccChronicleDataTable_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

type: Array
description: |-
Contains the list of scope names of the data table. If the list is empty,
the data table is treated as unscoped. The scope names should be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a separate comment as unable to unresolved: Would be great if you can test it once and confirm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked this by local testing. If we send the empty list in data access scope, unscoped table is created.

@harshita298 harshita298 force-pushed the chronicle-datatable-harshiita branch from b702df5 to 915c14e Compare March 9, 2026 10:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 486 insertions(+))
google-beta provider: Diff ( 6 files changed, 1706 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 22
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • chronicle

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample
  • TestAccChronicleDataTable_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataTable_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@harshita298 harshita298 force-pushed the chronicle-datatable-harshiita branch from 915c14e to 86e0142 Compare March 9, 2026 11:31
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 485 insertions(+))
google-beta provider: Diff ( 6 files changed, 1704 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_table (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_table" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 23
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • chronicle

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataTable_chronicleDataTableWithOptionalFieldsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terraform support for Chronicle Data Table resource

3 participants