Skip to content

Split TestAccContainerNodePool_EmptyGuestAccelerator into two tests#16602

Draft
zli82016 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:container-test-split
Draft

Split TestAccContainerNodePool_EmptyGuestAccelerator into two tests#16602
zli82016 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:container-test-split

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Mar 3, 2026

The field guest_accelerator is immutable. Split the original test with recreating step into two tests.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+))
google-beta provider: Diff ( 1 file changed, 17 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 283
Passed tests: 267
Skipped tests: 15
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerNodePool_PartialEmptyGuestAccelerator

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_PartialEmptyGuestAccelerator [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants