test: Move file_info_test.go to stretchr/testify

[kislaykishore]

Description

Move file_info_test.go to stretchr/testify

Link to the issue in case of a bug fix.

b/490422401

Testing details

1. Manual - NA
2. Unit tests - NA
3. Integration tests - NA

Any backward incompatible change? If so, please explain.

No

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (6497c37) to head (c284711).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4449       +/-   ##
===========================================
+ Coverage        0   83.38%   +83.38%     
===========================================
  Files           0      163      +163     
  Lines           0    19966    +19966     
===========================================
+ Hits            0    16648    +16648     
- Misses          0     2704     +2704     
- Partials        0      614      +614     

Flag	Coverage Δ
unittests	83.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the testing infrastructure for file_info_test.go by transitioning its test assertions and structure to leverage the widely adopted stretchr/testify library. This change aims to standardize the testing approach, improve readability, and align with common Go testing practices, making future test development and maintenance more consistent.

Highlights

• Testing Framework Migration: The test file file_info_test.go has been migrated from using the github.com/jacobsa/ogletest framework to github.com/stretchr/testify.
• Simplified Test Structure: The test suite setup, including TestFileInfo, fileInfoTestKey, fileInfoTest structs, and the init() function, has been removed, simplifying the test file's structure.
• Updated Assertions: All test assertions have been updated from AssertEq and ExpectEq to require.Equal and assert.Equal from the testify library.

Changelog

• internal/cache/data/file_info_test.go
  • Removed ogletest imports and added stretchr/testify imports.
  • Eliminated ogletest-specific test suite setup and registration.
  • Refactored test functions to accept *testing.T and use testify assertions.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully migrates file_info_test.go from ogletest to stretchr/testify. The changes are mostly correct, and the identified areas for improvement in testing practices remain valid as they do not contradict any of the provided repository-specific rules. The suggestions for using more idiomatic assertion functions like require.NoError and require.EqualError, and fixing a misnamed test case, are retained.

[github-actions]

Hi @ashmeenkaur, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!