test: disable flaky Test_validateCRC_WheContextIsCancelled

[kislaykishore]

Description

Disabled Test_validateCRC_WheContextIsCancelled in internal/cache/file/downloader/job_test.go because it is flaky. This test has been flaky for ~10 months. Disabling it.

Link to the issue in case of a bug fix.

b/416142095

Testing details

1. Manual - NA
2. Unit tests - NA
3. Integration tests - NA

Any backward incompatible change? If so, please explain.

No

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves continuous integration stability by disabling a unit test identified as persistently flaky. The Test_validateCRC_WheContextIsCancelled test, which has caused intermittent failures for an extended period, has been removed from the active test suite to prevent further disruptions to the CI pipeline.

Highlights

• Test Disablement: The Test_validateCRC_WheContextIsCancelled test in internal/cache/file/downloader/job_test.go has been disabled due to its persistent flakiness over approximately 10 months.

Changelog

• internal/cache/file/downloader/job_test.go
  • Disabled the Test_validateCRC_WheContextIsCancelled test by renaming its function signature and adding a comment explaining the change.

Activity

• No review comments or other activity have been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables a flaky test, Test_validateCRC_WheContextIsCancelled, by renaming it, which is an effective way to prevent it from running. My review includes a suggestion to add the associated issue number to the comment for better traceability. Additionally, you may want to consider adding an entry for this test in flaky_tests.lst to maintain a centralized list of flaky tests, following the existing pattern in that file.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (6497c37) to head (eaacb94).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4447       +/-   ##
===========================================
+ Coverage        0   83.33%   +83.33%     
===========================================
  Files           0      163      +163     
  Lines           0    19979    +19979     
===========================================
+ Hits            0    16650    +16650     
- Misses          0     2711     +2711     
- Partials        0      618      +618     

Flag	Coverage Δ
unittests	83.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Hi @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @charith87, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @charith87, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!