Skip to content

feat(consistent symlink): add resolveSymlinkTarget method to decipher symlink target for both standard and legacy symlinks #4434

Closed
anushka567 wants to merge 8 commits intosymlink-inode-read-methodfrom
resolve-symlink-target-helper-method
Closed

feat(consistent symlink): add resolveSymlinkTarget method to decipher symlink target for both standard and legacy symlinks #4434
anushka567 wants to merge 8 commits intosymlink-inode-read-methodfrom
resolve-symlink-target-helper-method

Conversation

@anushka567
Copy link
Copy Markdown
Member

Description

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.57%. Comparing base (6b08c36) to head (cf3d18e).
⚠️ Report is 56 commits behind head on symlink-inode-read-method.

Files with missing lines Patch % Lines
internal/fs/inode/dir.go 83.87% 3 Missing and 2 partials ⚠️
internal/fs/inode/symlink.go 94.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           symlink-inode-read-method    #4434      +/-   ##
=============================================================
- Coverage                      83.59%   83.57%   -0.02%     
=============================================================
  Files                            163      163              
  Lines                          19902    19940      +38     
=============================================================
+ Hits                           16637    16665      +28     
- Misses                          2648     2654       +6     
- Partials                         617      621       +4     
Flag Coverage Δ
unittests 83.57% <89.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anushka567 anushka567 force-pushed the symlink-inode-read-method branch 3 times, most recently from cb13716 to 5c8cc5f Compare March 25, 2026 05:55
@anushka567 anushka567 closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant