Skip to content

[Timeseries] Make processing time hint in seconds available in tests #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsdinter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Timeseries] Make processing time hint in seconds available in tests #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ming/timeseries-java-applications/TimeSeriesPipeline/src/test/java/common/TSTestData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,13 @@ public Builder setInputTSDataFromJSON(
if (advanceWatermark_expression == AdvanceWatermarkExpression.INFINITY) {
testStream = stream.advanceWatermarkToInfinity();
}
break;
case ADVANCE_PROCESSING_TIME_SECONDS:
Copy link
Collaborator

@rezarokni rezarokni Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other use case we need is to advance the watermark but then have a event that has timestamp > than the watermark.

For example:

event{timestamp: 1}
advanceWaterMark timestamp: 3
event{timestamp: 2}

stream =
stream.advanceProcessingTime(
Duration.standardSeconds(
tsTimePointTestBuilder.getTime().getAdvanceProcessingTimeSeconds()));
break;
}
}
tsTimePointTestBuilder.clear();
Expand Down
2 changes: 1 addition & 1 deletion ...ies-streaming/timeseries-java-applications/TimeSeriesPipeline/src/test/proto/TSTest.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ message Time {

int32 advance_watermark_seconds = 2;

int32 advance_processing_timeSeconds = 3;
int32 advance_processing_time_seconds = 3;
}
}

Expand Down