fix: Handle the errors when the listener socket is closed gracefully.#2373
Draft
fix: Handle the errors when the listener socket is closed gracefully.#2373
Conversation
hessjcg
force-pushed
the
gh-2372-exit-code-bug
branch
from
1a8e52b to
8be290e
Compare
Member
|
Nice find! This probably deserves a test, if only of the private method, so that future maintainers don't trip over this again. |
Collaborator
Author
|
I'm converting this back to a draft, because after some testing, the errors returned from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accept loop for socket connections now will properly handle the error case where the listener socket
is closed gracefully.
Fixes #2372