Use gcloud as a docker credential helper for all GCP registries.#428
Open
kmontg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Use gcloud as a docker credential helper for all GCP registries.#428kmontg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
kmontg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
This will make the image a bit easier to use CI where docker auth is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the image a bit easier to use in CI where docker auth is required. However, there is a warning that having a long credential helper list (like would be added from this change) introduces slowness in
docker buildcommands. I believe this is because docker will fetch the credentials for each registry in the config file before the build itself. An alternative would be to use the standalone credential helper, but it's not available as a gcloud component.