Skip to content
This repository was archived by the owner on Oct 11, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/src/mapreduce/input_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,11 @@ def _validate_filters(cls, filters, model_class):
"Property %s is not defined for entity type %s",
prop, model_class.kind())

if isinstance(properties[prop], db.ListProperty):
# for db.ListProperty validate expect a list, but filter expect
# a single value
val = [val]

# Validate the value of each filter. We need to know filters have
# valid value to carry out splits.
try:
Expand Down
6 changes: 6 additions & 0 deletions python/test/mapreduce/input_readers_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,12 @@ def testValidate_Filters(self):
self.reader_cls.validate,
mapper_spec)

params["filters"] = [('mvp_str', '=', '1')]
self.reader_cls.validate(mapper_spec)

params["filters"] = [('mvp_int', '=', 1)]
self.reader_cls.validate(mapper_spec)

def _set_vals(self, entities, a_vals, b_vals):
"""Set a, b values for entities."""
vals = []
Expand Down
5 changes: 5 additions & 0 deletions python/test/testlib/testutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ class TestEntity(db.Model):

a = db.IntegerProperty()
b = db.IntegerProperty()
mvp_str = db.StringListProperty()
mvp_int = db.ListProperty(int, required=True, indexed=True)


class NdbTestEntity(ndb.Model):
Expand All @@ -100,6 +102,9 @@ class NdbTestEntity(ndb.Model):
a = ndb.IntegerProperty()
b = ndb.IntegerProperty()

mvp_str = ndb.StringProperty(repeated=True)
mvp_int = ndb.IntegerProperty(repeated=True)


class TestEntityWithDot(db.Model):
"""Test entity class with dot in its kind."""
Expand Down