ci: declare contents: read on three workflows#3802
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
spanner-terraform-validator: PR-time terraform fmt/validate/README checks. upload-jar / upload-python-package: manual workflow_dispatch builds and uploads artifacts to GCS via the runner's pre-configured gcloud auth (not GITHUB_TOKEN). All three need only contents: read from the GitHub token. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
93b0de1 to
2faf1b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three workflows currently without explicit permissions:
spanner-terraform-validator— PR-timeterraform fmt -check,terraform validate, README convention check.upload-jar/upload-python-package— manualworkflow_dispatchjobs that build artifacts and upload to GCS. GCS auth uses the self-hosted runner`s preconfigured gcloud credentials, not GITHUB_TOKEN.All three only need
contents: readfrom the GitHub token foractions/checkout. The DataflowTemplates repo has 26 workflows total; 23 already declare permissions explicitly. This brings the remaining three in line.