Skip to content

Make job-builder-util-transform depend on Beam AWS packages.#3801

Open
chamikaramj wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
chamikaramj:job_builder_util_aws
Open

Make job-builder-util-transform depend on Beam AWS packages.#3801
chamikaramj wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
chamikaramj:job_builder_util_aws

Conversation

@chamikaramj
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project configuration to include the AWS extras for Apache Beam. This change ensures that the job-builder-util-transforms module has the necessary dependencies to support AWS-based operations within its data processing pipelines.

Highlights

  • Dependency Update: Added the 'aws' extra to the apache-beam dependency in pyproject.toml to enable AWS-related functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the "aws" extra to the apache-beam dependency in the pyproject.toml file. The review feedback identifies a potential versioning error, suggesting that version ^2.72.0 may be a typo for a stable release like ^2.61.0, and recommends alphabetizing the extras list for better maintainability.

Comment thread python/src/main/python/job-builder-util-transforms/pyproject.toml
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.19%. Comparing base (a65f9ce) to head (232ad13).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a65f9ce) and HEAD (232ad13). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a65f9ce) HEAD (232ad13)
4 2
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3801       +/-   ##
=============================================
- Coverage     53.48%   37.19%   -16.30%     
+ Complexity     6656      471     -6185     
=============================================
  Files          1085      194      -891     
  Lines         66443    11416    -55027     
  Branches       7399     1130     -6269     
=============================================
- Hits          35540     4246    -31294     
+ Misses        28509     6832    -21677     
+ Partials       2394      338     -2056     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 913 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chamikaramj chamikaramj added dependencies Pull requests that update a dependency file package-upgrade and removed dependencies Pull requests that update a dependency file labels May 13, 2026
@chamikaramj chamikaramj requested a review from derrickaw May 13, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants