improvement: Bigtable to Parquet Template config options#3782
improvement: Bigtable to Parquet Template config options#3782brandtnewton wants to merge 4 commits into
Conversation
8dec2f5 to
cb9982e
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3782 +/- ##
=============================================
+ Coverage 33.47% 53.48% +20.01%
- Complexity 482 6245 +5763
=============================================
Files 215 1085 +870
Lines 12891 66446 +53555
Branches 1262 7399 +6137
=============================================
+ Hits 4315 35539 +31224
- Misses 8236 28512 +20276
- Partials 340 2395 +2055
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Bigtable to Parquet template by providing users with the flexibility to configure read row timeouts. By exposing these settings as template parameters, users can now adjust the attempt and operation timeouts to better suit their specific workload requirements, improving the robustness of data migration processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces configurable timeouts for Bigtable read operations in the BigtableToParquet template by adding 'readRowsAttemptTimeout' and 'readRowsOperationTimeout' to the pipeline options. Feedback suggests using 'ValueProvider' for these new options to maintain consistency with the existing codebase, as well as adding '@SuppressWarnings("unused")' to setters and marking the template parameters as optional.
…es into timeout-fix
Some users have requested the ability to configure longer read row timeouts for the Bigtable to Parquet Template.