Merged
Conversation
khoi
requested changes
Jun 10, 2025
| } else if let widthAttr = attributes[ignoreCase: "width"], | ||
| let heightAttr = attributes[ignoreCase: "height"], | ||
| let width = SVGLengthParser.xAxis.double(string: widthAttr, context: context), | ||
| let height = SVGLengthParser.yAxis.double(string: heightAttr, context: context) { |
Collaborator
There was a problem hiding this comment.
The SVGLengthParser parse % props to absolute values based on the parent width, height (fetched from context).
I wonder what would be the values parsed here for width and height, can u please check?
Author
There was a problem hiding this comment.
Refer to the results in viewport-02.ref, if the % is used in the viewport attribute, the size will be 100x100.
khoi
requested changes
Jun 12, 2025
|
|
||
| class SVGRectParser: SVGShapeParser { | ||
| override func parseLocus(context: SVGNodeContext) -> SVGShape? { | ||
| // SVGHelper.parseDimension(attributes, "markerWidth") ?? SVGLength(percent: 100) |
khoi
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://goodnotes.atlassian.net/browse/FFA-502
Pedro shares the example below. The problem is that the canvas definition does not use "viewBox" and uses "width" and "height" attributes instead. As the default size of the canvas is 100 x 100, when the library parses
<rect width="100%" height="100%" fill="#f4f4f4"/>which uses the parent context size, the rect size is 100x100, instead of 780 x 950.