Skip to content

fix(streaming-widget): finalize bounty coverage and evidence#38

Open
edehvictor wants to merge 2 commits into
GoodDollar:copilot/create-streaming-widgetfrom
edehvictor:fix/finalize-streaming-widget-36
Open

fix(streaming-widget): finalize bounty coverage and evidence#38
edehvictor wants to merge 2 commits into
GoodDollar:copilot/create-streaming-widgetfrom
edehvictor:fix/finalize-streaming-widget-36

Conversation

@edehvictor
Copy link
Copy Markdown
Collaborator

Refs #26
Refs #28
Refs #36
Builds on AI PR #31.

Summary

Finalizes the streaming widget bounty work on top of the existing AI PR branch by filling the missing runtime states, deterministic Storybook coverage, Playwright coverage, and screenshot evidence needed for human review.

Changes

  • Kept the widget shell on WidgetTabs for Streams, Pools, and Balances.
  • Added deterministic StreamingWidgetPreview wiring for Storybook and Playwright while preserving the live StreamingWidget adapter path.
  • Added stream history state to the runtime contract, adapter, and UI, including loading, empty, error, populated, and Show more states.
  • Added live GDA pool claim support by reading getClaimableNow from pool contracts and submitting claimAll, with separate pending/success/error state.
  • Strengthened create/update stream UI for invalid input, disconnected wallet, wrong chain, pending, success, and failure states.
  • Preserved injected wallet and custodial fixture stories, and added deterministic stories for loading, empty, error, create/update, pool claim, Base SUP balance/reserve, and non-Base reserve-disabled states.
  • Replaced the streaming-widget Playwright smoke tests with deterministic coverage for tab navigation, stream filters/history, create/update success/failure, pool claim state, reserve visibility by chain, and mobile/desktop layout evidence.
  • Added current screenshot evidence under tests/widgets/streaming-widget/test-results/.
  • Fixed small pre-existing lint blockers outside the widget package so the required full pnpm lint command passes.

Verification

  • pnpm install: Passed
  • pnpm build: Passed
  • pnpm lint: Passed with existing repo warnings only
  • pnpm test:demo tests/widgets/streaming-widget: Passed, 13/13 tests
  • git diff --check HEAD~2..HEAD: Passed, no whitespace errors

Evidence

Playwright screenshots are committed in tests/widgets/streaming-widget/test-results/ and cover:

  • disconnected wallet
  • tab navigation
  • wrong chain
  • loading, empty, error, and populated stream/history states
  • create/update invalid, pending, success, and failure states
  • pool claim idle, pending, success, and error states
  • Base SUP reserve and non-Base reserve-disabled states
  • mobile and desktop populated layouts

Notes

This PR intentionally targets copilot/create-streaming-widget so AI PR #31 can be updated before maintainer review.

@edehvictor
Copy link
Copy Markdown
Collaborator Author

Hi @L03TJ3, PR #38 is ready for review.

I followed the assigned bounty flow, built on top of the existing AI branch, posted the handoff on #36, and included verification/evidence.

Verified:

  • pnpm install
  • pnpm build
  • pnpm lint
  • pnpm test:demo tests/widgets/streaming-widget passing, 13/13

Thanks again for assigning this.

@L03TJ3 L03TJ3 linked an issue May 22, 2026 that may be closed by this pull request
12 tasks
@L03TJ3 L03TJ3 removed this from GoodBounties May 22, 2026
@L03TJ3 L03TJ3 requested review from a team, L03TJ3 and pheobeayo and removed request for a team and L03TJ3 May 22, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GoodBounty] Finalize Streaming Widget PR

2 participants