fix: normalize checksum asset paths#877
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes wfctl update checksum verification failures for releases whose checksums.txt records assets with a leading ./ by normalizing checksum entry filenames before lookup, and adds regression coverage for the v0.75.0 checksum format.
Changes:
- Normalize leading
./inchecksums.txtfilenames during parsing to match release asset names. - Reject conflicting checksum entries that normalize to the same filename.
- Add regression tests covering
./-prefixed checksum entries for both parsing andwfctl updateverification.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/wfctl/plugin_checksum.go | Normalizes ./ prefix in parsed checksum entry names and detects conflicts. |
| cmd/wfctl/plugin_checksum_test.go | Adds parser tests for ./ normalization and conflict rejection. |
| cmd/wfctl/update_test.go | Adds a regression test ensuring checksum verification accepts ./-prefixed asset entries. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./inchecksums.txtasset names before lookup./checksum aliases for the same normalized asset namewfctl updateregression coverage for the v0.75.0 checksum formatVerification
GOWORK=off go test ./cmd/wfctl -run TestVerifyAssetChecksum_AcceptsDotSlashAssetPrefix -count=1failed before the fix withchecksum for "wfctl-darwin-arm64" not found in checksums.txtGOWORK=off go test ./cmd/wfctl -run 'TestParseChecksumsTxt|TestLookupChecksumForURL|TestVerifyAssetChecksum' -count=1\n-GOWORK=off go test ./cmd/wfctl -count=1\n-GOWORK=off golangci-lint run --timeout=5m\n-git diff --check\n