ci: modernize generated action defaults#870
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes this repo’s CI and all generator/scaffolded GitHub Actions surfaces by bumping the default toolchain to Node.js 24 and Go 1.26.4, refreshing pinned action SHAs, and tightening workflow shell snippets/actionlint compliance.
Changes:
- Bump Go/toolchain defaults across modules, templates, examples, docs, and tests to Go 1.26.4 (and Node.js to 24 where relevant).
- Refresh pinned GitHub Actions references (e.g., checkout/setup-node/github-script/cache/artifacts/docker) to newer SHAs/versions.
- Disable
actions/setup-gobuilt-in caching and clean up workflow shell scripting (quoting,read -r, etc.).
Reviewed changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates Node.js requirement; (still documents Go as 1.26+). |
| mcp/wfctl_tools.go | Updates generated workflow Go version to 1.26.4. |
| mcp/github_actions_refs.go | Updates pinned docker action SHAs used by MCP-generated content. |
| go.mod | Bumps module Go version to 1.26.4. |
| example/go.mod | Bumps example module Go version to 1.26.4. |
| example/ecommerce-app/README.md | Updates documented Dockerfile Go image version. |
| DOCUMENTATION.md | Updates documented Docker step image to golang:1.26.4. |
| docs/tutorials/deploy-pipeline.md | Updates workflow snippet Go version to 1.26.4. |
| docs/tutorials/building-apps-with-workflow.md | Updates Node.js optional prereq; Go prereq remains older. |
| docs/APPLICATION_UI_CONTRACT.md | Updates Dockerfile examples to node:24 and golang:1.26.4. |
| docs/ADMIN_UI_FEATURES.md | Updates narrative Go version references around r.Pattern. |
| data/registry/templates/ui-plugin.yaml | Updates Node.js requirement in registry template notes. |
| data/registry/.github/workflows/validate.yml | Pins checkout/setup-node and bumps Node to 24 for registry validation. |
| CONTRIBUTING.md | Updates Node.js prerequisite (Go still documented as 1.26+). |
| cmd/wfctl/testdata/verify_capabilities/version-drift/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/release-good/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/name-drift/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/missing-ldflag/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/iac-missing-service/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/iac-good/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/iac-extra-service/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/verify_capabilities/good/go.mod | Bumps Go version in capability test fixture. |
| cmd/wfctl/testdata/conformance/no-iac/go.mod | Bumps Go version in conformance test fixture. |
| cmd/wfctl/testdata/conformance/iac-pass/go.mod | Bumps Go version in conformance test fixture. |
| cmd/wfctl/testdata/conformance/iac-hang/go.mod | Bumps Go version in conformance test fixture. |
| cmd/wfctl/templates/ui-plugin/go.mod.tmpl | Bumps scaffold template Go version to 1.26.4. |
| cmd/wfctl/templates/ui-plugin/.github/workflows/release.yml.tmpl | Bumps scaffolded release workflow Go version to 1.26.4. |
| cmd/wfctl/templates/plugin/go.mod.tmpl | Bumps scaffold template Go version to 1.26.4. |
| cmd/wfctl/templates/plugin/.github/workflows/release.yml.tmpl | Bumps scaffolded release workflow Go version to 1.26.4. |
| cmd/wfctl/templates/full-stack/README.md.tmpl | Bumps scaffold README prereqs (Go/Node) to 1.26.4/24. |
| cmd/wfctl/templates/full-stack/go.mod.tmpl | Bumps scaffold template Go version to 1.26.4. |
| cmd/wfctl/templates/full-stack/Dockerfile.tmpl | Bumps scaffold Dockerfile images to node:24 and golang:1.26.4. |
| cmd/wfctl/templates/full-stack/.github/workflows/ci.yml.tmpl | Bumps scaffolded CI workflow Go version to 1.26.4 and Node to 24. |
| cmd/wfctl/templates/event-processor/README.md.tmpl | Bumps scaffold README prereq Go version to 1.26.4. |
| cmd/wfctl/templates/event-processor/go.mod.tmpl | Bumps scaffold template Go version to 1.26.4. |
| cmd/wfctl/templates/event-processor/Dockerfile.tmpl | Bumps scaffold Dockerfile image to golang:1.26.4. |
| cmd/wfctl/templates/event-processor/.github/workflows/ci.yml.tmpl | Bumps scaffolded CI workflow Go version to 1.26.4. |
| cmd/wfctl/templates/api-service/README.md.tmpl | Bumps scaffold README prereq Go version to 1.26.4. |
| cmd/wfctl/templates/api-service/go.mod.tmpl | Bumps scaffold template Go version to 1.26.4. |
| cmd/wfctl/templates/api-service/Dockerfile.tmpl | Bumps scaffold Dockerfile image to golang:1.26.4. |
| cmd/wfctl/templates/api-service/.github/workflows/ci.yml.tmpl | Bumps scaffolded CI workflow Go version to 1.26.4. |
| cmd/wfctl/plugin_conformance_test.go | Updates dynamically-written fixture go.mod Go version. |
| cmd/wfctl/generate.go | Updates wfctl-generated workflow defaults and pinned docker action SHAs. |
| cmd/wfctl/deploy.go | Updates generated Dockerfile base image to golang:1.26.4-alpine. |
| cmd/wfctl/build_security_audit_test.go | Updates expected Dockerfile snippets to golang:1.26.4-alpine. |
| cigen/testdata/multisite/generated-infra.yml | Updates pinned actions/github-script ref in generated testdata. |
| cigen/render_gha.go | Updates pinned actions/github-script ref in cigen output. |
| cigen/render_gha_test.go | Updates tests to expect the new pinned github-script ref and reject v9 moving tags. |
| CICD_PLAN.md | Updates Node image used in CI plan example to node:24-alpine. |
| .github/workflows/test-dispatch.yml | Updates repository-dispatch comment/version annotation. |
| .github/workflows/release.yml | Bumps Go version to 1.26.4, disables setup-go cache, updates artifact/cache action SHAs, and tightens shell snippets. |
| .github/workflows/pre-release.yml | Bumps Go version to 1.26.4, disables setup-go cache, and tightens shell snippets. |
| .github/workflows/osv-scanner.yml | Updates osv-scanner reusable workflow pins. |
| .github/workflows/helm-lint.yml | Updates azure/setup-helm annotation/version comment. |
| .github/workflows/dependency-update.yml | Bumps Go version to 1.26.4, disables setup-go cache, and updates create-pull-request pin. |
| .github/workflows/create-release.yml | Updates upload-artifact pin to v7.0.1 SHA. |
| .github/workflows/copilot-setup-steps.yml | Disables setup-go cache and updates docker/setup-buildx pin. |
| .github/workflows/conformance-smoke.yml | Bumps Go version to 1.26.4 and disables setup-go cache. |
| .github/workflows/conformance-budget-check.yml | Updates actions/cache pin/comment to v5.0.5. |
| .github/workflows/codeql.yml | Bumps Go version to 1.26.4, disables setup-go cache, and updates CodeQL action annotations. |
| .github/workflows/ci.yml | Bumps Go version to 1.26.4, disables setup-go cache across jobs, updates artifact/cache/github-script pins, and refactors shell snippets for actionlint. |
| .github/workflows/ci-wfctl.yml.example | Updates example workflow pins and Go version comment. |
| .github/workflows/benchmark.yml | Bumps Go version to 1.26.4, disables setup-go cache, updates cache/github-script/upload-artifact pins. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification