feat(wfctl): discover manifest-driven secrets#867
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends wfctl secrets setup with a manifest-driven mode that can discover required secrets from wfctl.yaml / .wfctl-lock.yaml, installed plugin required_secrets[], and ${ENV_VAR} references found in workflow config YAMLs, then guides GitHub Actions secret setup at repo/env/org scopes using the existing setup engine.
Changes:
- Add
--manifestflow towfctl secrets setup, including discovery from manifest + lockfile + config env references. - Enhance plugin manifest loading to match real install layouts (full name, normalized provider name, or
workflow-plugin-<provider>). - Update docs to describe manifest-driven secret setup and improved scope guidance.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/WFCTL.md | Documents secrets setup --manifest and related flags/examples. |
| docs/wfctl-secrets-scopes.md | Clarifies plugin manifest lookup behavior and adds repo-level manifest-driven setup example. |
| docs/iac-dns-providers.md | Adds manifest-driven secrets setup guidance for provider plugins. |
| cmd/wfctl/secrets_setup.go | Routes secrets setup to manifest-driven implementation when --manifest is present. |
| cmd/wfctl/secrets_setup_plugin.go | Updates plugin manifest resolution to try multiple candidate install directories. |
| cmd/wfctl/secrets_setup_plugin_test.go | Adds coverage for loading plugin manifests from normalized install directories. |
| cmd/wfctl/secrets_setup_manifest.go | Implements manifest-driven secret discovery + setup engine integration. |
| cmd/wfctl/secrets_setup_manifest_test.go | Adds tests for discovery and manifest flag parsing. |
Comment on lines
+64
to
+72
| if in != nil { | ||
| for _, kv := range readKVLines(in) { | ||
| k, v, ok := strings.Cut(kv, "=") | ||
| if ok { | ||
| secretMap[k] = v | ||
| } | ||
| } | ||
| } | ||
| interactive := in == nil && isatty.IsTerminal(os.Stdin.Fd()) |
| if err := fs.Parse(args); err != nil { | ||
| return nil, err | ||
| } | ||
| _ = nonInteractive |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wfctl secrets setup --manifest wfctl.yamlto discover secrets fromwfctl.yaml,.wfctl-lock.yaml, installed pluginrequired_secrets[], and${ENV_VAR}references in config YAML.--from-env,--secret, interactive prompts,--only, and--skip-existingbehavior.workflow-plugin-<provider>.Verification
GOWORK=off go test ./cmd/wfctl -run 'TestDiscoverManifestSecrets|TestParseManifestSetupFlags|TestLoadPluginManifest' -count=1GOWORK=off go test ./cmd/wfctl -count=1git diff --check HEAD~1..HEADFixes #864