fix(wfctl): address download review feedback#861
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines wfctl download behavior and related tests by tightening GitHub release asset metadata request cancellation, improving regression test robustness by capturing stderr, and making download byte-unit capping follow the configured prefix table.
Changes:
- Adjust GitHub release asset metadata timeout cancellation flow to explicitly cancel on all early-return paths and after metadata decode.
- Update the direct-download bounded-context regression test to capture stderr output during the download.
- Make
formatDownloadBytescap units based on the prefix table length instead of a hard-coded limit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/wfctl/plugin_install.go | Refines metadata request cancellation handling in the GitHub release asset download flow. |
| cmd/wfctl/plugin_install_test.go | Captures stderr during a direct-download regression test to avoid noisy output and better match runtime behavior. |
| cmd/wfctl/download_progress.go | Removes a hard-coded unit cap by basing unit selection on the prefix table length. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification