Skip to content

docs(dns): delegation portfolio retro + scope-lock complete#859

Merged
intel352 merged 1 commit into
mainfrom
chore/dns-delegation-retro
Jun 5, 2026
Merged

docs(dns): delegation portfolio retro + scope-lock complete#859
intel352 merged 1 commit into
mainfrom
chore/dns-delegation-retro

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 5, 2026

Closes the DNS-delegation-portfolio locked plan (Status→Complete, lock removed) + post-merge retro. Doc-only. Live-validated: 30/30 catalog snapshots carry both authority(registrar+live NS) + records; 15 delegated-away flagged.

Status Locked->Complete (live-validated: 30/30 snapshots both layers; import
run imported 30 infra.dns_delegation). Retro: adversarial gates caught 3
pre-merge bugs; live validation caught 3 runtime-only (429, the 404
delegation-read-never-live-tested endpoint, the verify-capabilities version gate).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 5, 2026 06:27
@intel352 intel352 merged commit 1562d1b into main Jun 5, 2026
15 checks passed
@intel352 intel352 deleted the chore/dns-delegation-retro branch June 5, 2026 06:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Doc-only PR that closes out the DNS delegation portfolio work by (1) recording a post-merge retrospective and (2) marking the implementation plan as complete while removing the scope-lock hash file.

Changes:

  • Added a retro documenting outcomes, validation results, and lessons learned for capturing both registrar NS delegation and hosted records in the DNS catalog.
  • Updated the DNS delegation portfolio plan status from Locked to Complete.
  • Removed the plan’s .scope-lock hash file as part of unlocking/closeout.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/retros/2026-06-05-dns-delegation-portfolio-retro.md Adds the post-merge retrospective for the DNS delegation portfolio effort.
docs/plans/2026-06-02-dns-delegation-portfolio.md.scope-lock Removes the scope-lock hash file to reflect closeout/unlock.
docs/plans/2026-06-02-dns-delegation-portfolio.md Marks the plan status as Complete with timestamp.


**Date:** 2026-06-05
**Scope:** workflow v0.71.0 + workflow-plugin-hover v0.5.2→v0.5.4 + gocodealone-dns import-dns delegation
**Artifacts:** design `docs/plans/2026-06-02-dns-delegation-portfolio-design.md` (3 revs) · plan `...portfolio.md` (3 revs, scope-locked→complete) · ADR 0047
Comment on lines +3 to +4
**Date:** 2026-06-05
**Scope:** workflow v0.71.0 + workflow-plugin-hover v0.5.2→v0.5.4 + gocodealone-dns import-dns delegation
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

⏱ Benchmark Results

No significant performance regressions detected.

benchstat comparison (baseline → PR)
## benchstat: baseline → PR
baseline-bench.txt:304: parsing iteration count: invalid syntax
baseline-bench.txt:325325: parsing iteration count: invalid syntax
baseline-bench.txt:644142: parsing iteration count: invalid syntax
baseline-bench.txt:939298: parsing iteration count: invalid syntax
baseline-bench.txt:1230878: parsing iteration count: invalid syntax
baseline-bench.txt:1534422: parsing iteration count: invalid syntax
benchmark-results.txt:304: parsing iteration count: invalid syntax
benchmark-results.txt:335573: parsing iteration count: invalid syntax
benchmark-results.txt:679278: parsing iteration count: invalid syntax
benchmark-results.txt:1026586: parsing iteration count: invalid syntax
benchmark-results.txt:1367114: parsing iteration count: invalid syntax
benchmark-results.txt:1703634: parsing iteration count: invalid syntax
goos: linux
goarch: amd64
pkg: github.com/GoCodeAlone/workflow/dynamic
cpu: AMD EPYC 7763 64-Core Processor                
                            │ baseline-bench.txt │
                            │       sec/op       │
InterpreterCreation-4               7.589m ± 59%
ComponentLoad-4                     3.574m ± 10%
ComponentExecute-4                  1.919µ ±  0%
PoolContention/workers-1-4          1.076µ ±  2%
PoolContention/workers-2-4          1.081µ ±  2%
PoolContention/workers-4-4          1.084µ ±  1%
PoolContention/workers-8-4          1.082µ ±  4%
PoolContention/workers-16-4         1.085µ ±  0%
ComponentLifecycle-4                3.590m ±  1%
SourceValidation-4                  2.306µ ±  1%
RegistryConcurrent-4                797.9n ±  2%
LoaderLoadFromString-4              3.587m ±  2%
geomean                             18.70µ

                            │ baseline-bench.txt │
                            │        B/op        │
InterpreterCreation-4               2.027Mi ± 0%
ComponentLoad-4                     2.180Mi ± 0%
ComponentExecute-4                  1.203Ki ± 0%
PoolContention/workers-1-4          1.203Ki ± 0%
PoolContention/workers-2-4          1.203Ki ± 0%
PoolContention/workers-4-4          1.203Ki ± 0%
PoolContention/workers-8-4          1.203Ki ± 0%
PoolContention/workers-16-4         1.203Ki ± 0%
ComponentLifecycle-4                2.183Mi ± 0%
SourceValidation-4                  1.984Ki ± 0%
RegistryConcurrent-4                1.133Ki ± 0%
LoaderLoadFromString-4              2.182Mi ± 0%
geomean                             15.25Ki

                            │ baseline-bench.txt │
                            │     allocs/op      │
InterpreterCreation-4                15.68k ± 0%
ComponentLoad-4                      18.02k ± 0%
ComponentExecute-4                    25.00 ± 0%
PoolContention/workers-1-4            25.00 ± 0%
PoolContention/workers-2-4            25.00 ± 0%
PoolContention/workers-4-4            25.00 ± 0%
PoolContention/workers-8-4            25.00 ± 0%
PoolContention/workers-16-4           25.00 ± 0%
ComponentLifecycle-4                 18.07k ± 0%
SourceValidation-4                    32.00 ± 0%
RegistryConcurrent-4                  2.000 ± 0%
LoaderLoadFromString-4               18.06k ± 0%
geomean                               183.3

cpu: AMD EPYC 9V74 80-Core Processor                
                            │ benchmark-results.txt │
                            │        sec/op         │
InterpreterCreation-4                  7.898m ± 63%
ComponentLoad-4                        3.497m ±  1%
ComponentExecute-4                     1.850µ ±  2%
PoolContention/workers-1-4             1.019µ ±  4%
PoolContention/workers-2-4             1.037µ ±  6%
PoolContention/workers-4-4             1.037µ ±  2%
PoolContention/workers-8-4             1.010µ ±  1%
PoolContention/workers-16-4            1.014µ ±  3%
ComponentLifecycle-4                   3.580m ±  0%
SourceValidation-4                     2.190µ ±  1%
RegistryConcurrent-4                   786.4n ±  8%
LoaderLoadFromString-4                 3.631m ±  1%
geomean                                18.15µ

                            │ benchmark-results.txt │
                            │         B/op          │
InterpreterCreation-4                  2.027Mi ± 0%
ComponentLoad-4                        2.180Mi ± 0%
ComponentExecute-4                     1.203Ki ± 0%
PoolContention/workers-1-4             1.203Ki ± 0%
PoolContention/workers-2-4             1.203Ki ± 0%
PoolContention/workers-4-4             1.203Ki ± 0%
PoolContention/workers-8-4             1.203Ki ± 0%
PoolContention/workers-16-4            1.203Ki ± 0%
ComponentLifecycle-4                   2.183Mi ± 0%
SourceValidation-4                     1.984Ki ± 0%
RegistryConcurrent-4                   1.133Ki ± 0%
LoaderLoadFromString-4                 2.182Mi ± 0%
geomean                                15.25Ki

                            │ benchmark-results.txt │
                            │       allocs/op       │
InterpreterCreation-4                   15.68k ± 0%
ComponentLoad-4                         18.02k ± 0%
ComponentExecute-4                       25.00 ± 0%
PoolContention/workers-1-4               25.00 ± 0%
PoolContention/workers-2-4               25.00 ± 0%
PoolContention/workers-4-4               25.00 ± 0%
PoolContention/workers-8-4               25.00 ± 0%
PoolContention/workers-16-4              25.00 ± 0%
ComponentLifecycle-4                    18.07k ± 0%
SourceValidation-4                       32.00 ± 0%
RegistryConcurrent-4                     2.000 ± 0%
LoaderLoadFromString-4                  18.06k ± 0%
geomean                                  183.3

pkg: github.com/GoCodeAlone/workflow/middleware
cpu: AMD EPYC 7763 64-Core Processor                
                                  │ baseline-bench.txt │
                                  │       sec/op       │
CircuitBreakerDetection-4                  286.1n ± 1%
CircuitBreakerExecution_Success-4          21.45n ± 1%
CircuitBreakerExecution_Failure-4          65.40n ± 0%
geomean                                    73.76n

                                  │ baseline-bench.txt │
                                  │        B/op        │
CircuitBreakerDetection-4                 144.0 ± 0%
CircuitBreakerExecution_Success-4         0.000 ± 0%
CircuitBreakerExecution_Failure-4         0.000 ± 0%
geomean                                              ¹
¹ summaries must be >0 to compute geomean

                                  │ baseline-bench.txt │
                                  │     allocs/op      │
CircuitBreakerDetection-4                 1.000 ± 0%
CircuitBreakerExecution_Success-4         0.000 ± 0%
CircuitBreakerExecution_Failure-4         0.000 ± 0%
geomean                                              ¹
¹ summaries must be >0 to compute geomean

cpu: AMD EPYC 9V74 80-Core Processor                
                                  │ benchmark-results.txt │
                                  │        sec/op         │
CircuitBreakerDetection-4                     299.6n ± 5%
CircuitBreakerExecution_Success-4             22.67n ± 1%
CircuitBreakerExecution_Failure-4             71.03n ± 1%
geomean                                       78.43n

                                  │ benchmark-results.txt │
                                  │         B/op          │
CircuitBreakerDetection-4                    144.0 ± 0%
CircuitBreakerExecution_Success-4            0.000 ± 0%
CircuitBreakerExecution_Failure-4            0.000 ± 0%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean

                                  │ benchmark-results.txt │
                                  │       allocs/op       │
CircuitBreakerDetection-4                    1.000 ± 0%
CircuitBreakerExecution_Success-4            0.000 ± 0%
CircuitBreakerExecution_Failure-4            0.000 ± 0%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/module
cpu: AMD EPYC 7763 64-Core Processor                
                                 │ baseline-bench.txt │
                                 │       sec/op       │
IaCStateBackend_InProcess-4              308.0n ±  1%
IaCStateBackend_GRPC-4                   9.437m ± 15%
JQTransform_Simple-4                     669.4n ± 38%
JQTransform_ObjectConstruction-4         1.536µ ±  3%
JQTransform_ArraySelect-4                3.469µ ±  0%
JQTransform_Complex-4                    40.28µ ±  0%
JQTransform_Throughput-4                 1.863µ ±  1%
SSEPublishDelivery-4                     67.33n ±  0%
geomean                                  3.889µ

                                 │ baseline-bench.txt │
                                 │        B/op        │
IaCStateBackend_InProcess-4              416.0 ± 0%
IaCStateBackend_GRPC-4                 5.832Mi ± 9%
JQTransform_Simple-4                   1.273Ki ± 0%
JQTransform_ObjectConstruction-4       1.773Ki ± 0%
JQTransform_ArraySelect-4              2.625Ki ± 0%
JQTransform_Complex-4                  16.31Ki ± 0%
JQTransform_Throughput-4               1.984Ki ± 0%
SSEPublishDelivery-4                     0.000 ± 0%
geomean                                             ¹
¹ summaries must be >0 to compute geomean

                                 │ baseline-bench.txt │
                                 │     allocs/op      │
IaCStateBackend_InProcess-4              2.000 ± 0%
IaCStateBackend_GRPC-4                  6.843k ± 0%
JQTransform_Simple-4                     10.00 ± 0%
JQTransform_ObjectConstruction-4         15.00 ± 0%
JQTransform_ArraySelect-4                30.00 ± 0%
JQTransform_Complex-4                    328.0 ± 0%
JQTransform_Throughput-4                 17.00 ± 0%
SSEPublishDelivery-4                     0.000 ± 0%
geomean                                             ¹
¹ summaries must be >0 to compute geomean

cpu: AMD EPYC 9V74 80-Core Processor                
                                 │ benchmark-results.txt │
                                 │        sec/op         │
IaCStateBackend_InProcess-4                 295.1n ± 37%
IaCStateBackend_GRPC-4                      10.21m ±  1%
JQTransform_Simple-4                        670.0n ± 30%
JQTransform_ObjectConstruction-4            1.462µ ±  1%
JQTransform_ArraySelect-4                   3.457µ ±  0%
JQTransform_Complex-4                       42.16µ ±  1%
JQTransform_Throughput-4                    1.768µ ±  2%
SSEPublishDelivery-4                        65.19n ±  1%
geomean                                     3.863µ

                                 │ benchmark-results.txt │
                                 │         B/op          │
IaCStateBackend_InProcess-4                416.0 ±  0%
IaCStateBackend_GRPC-4                   5.913Mi ± 14%
JQTransform_Simple-4                     1.273Ki ±  0%
JQTransform_ObjectConstruction-4         1.773Ki ±  0%
JQTransform_ArraySelect-4                2.625Ki ±  0%
JQTransform_Complex-4                    16.31Ki ±  0%
JQTransform_Throughput-4                 1.984Ki ±  0%
SSEPublishDelivery-4                       0.000 ±  0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                 │ benchmark-results.txt │
                                 │       allocs/op       │
IaCStateBackend_InProcess-4                 2.000 ± 0%
IaCStateBackend_GRPC-4                     6.866k ± 0%
JQTransform_Simple-4                        10.00 ± 0%
JQTransform_ObjectConstruction-4            15.00 ± 0%
JQTransform_ArraySelect-4                   30.00 ± 0%
JQTransform_Complex-4                       328.0 ± 0%
JQTransform_Throughput-4                    17.00 ± 0%
SSEPublishDelivery-4                        0.000 ± 0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/schema
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ baseline-bench.txt │
                                    │       sec/op       │
SchemaValidation_Simple-4                    1.099µ ± 4%
SchemaValidation_AllFields-4                 1.689µ ± 4%
SchemaValidation_FormatValidation-4          1.606µ ± 2%
SchemaValidation_ManySchemas-4               1.796µ ± 1%
geomean                                      1.521µ

                                    │ baseline-bench.txt │
                                    │        B/op        │
SchemaValidation_Simple-4                   0.000 ± 0%
SchemaValidation_AllFields-4                0.000 ± 0%
SchemaValidation_FormatValidation-4         0.000 ± 0%
SchemaValidation_ManySchemas-4              0.000 ± 0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                    │ baseline-bench.txt │
                                    │     allocs/op      │
SchemaValidation_Simple-4                   0.000 ± 0%
SchemaValidation_AllFields-4                0.000 ± 0%
SchemaValidation_FormatValidation-4         0.000 ± 0%
SchemaValidation_ManySchemas-4              0.000 ± 0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

cpu: AMD EPYC 9V74 80-Core Processor                
                                    │ benchmark-results.txt │
                                    │        sec/op         │
SchemaValidation_Simple-4                      1.081µ ± 21%
SchemaValidation_AllFields-4                   1.622µ ±  1%
SchemaValidation_FormatValidation-4            1.572µ ±  1%
SchemaValidation_ManySchemas-4                 1.588µ ±  4%
geomean                                        1.446µ

                                    │ benchmark-results.txt │
                                    │         B/op          │
SchemaValidation_Simple-4                      0.000 ± 0%
SchemaValidation_AllFields-4                   0.000 ± 0%
SchemaValidation_FormatValidation-4            0.000 ± 0%
SchemaValidation_ManySchemas-4                 0.000 ± 0%
geomean                                                   ¹
¹ summaries must be >0 to compute geomean

                                    │ benchmark-results.txt │
                                    │       allocs/op       │
SchemaValidation_Simple-4                      0.000 ± 0%
SchemaValidation_AllFields-4                   0.000 ± 0%
SchemaValidation_FormatValidation-4            0.000 ± 0%
SchemaValidation_ManySchemas-4                 0.000 ± 0%
geomean                                                   ¹
¹ summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/store
cpu: AMD EPYC 7763 64-Core Processor                
                                   │ baseline-bench.txt │
                                   │       sec/op       │
EventStoreAppend_InMemory-4                1.315µ ± 18%
EventStoreAppend_SQLite-4                  1.229m ±  6%
GetTimeline_InMemory/events-10-4           13.91µ ±  5%
GetTimeline_InMemory/events-50-4           81.45µ ±  3%
GetTimeline_InMemory/events-100-4          161.6µ ±  2%
GetTimeline_InMemory/events-500-4          627.2µ ±  0%
GetTimeline_InMemory/events-1000-4         1.279m ±  2%
GetTimeline_SQLite/events-10-4             70.75µ ±  0%
GetTimeline_SQLite/events-50-4             214.0µ ±  0%
GetTimeline_SQLite/events-100-4            388.0µ ±  1%
GetTimeline_SQLite/events-500-4            1.765m ±  0%
GetTimeline_SQLite/events-1000-4           3.498m ±  2%
geomean                                    212.8µ

                                   │ baseline-bench.txt │
                                   │        B/op        │
EventStoreAppend_InMemory-4                  771.0 ± 6%
EventStoreAppend_SQLite-4                  1.985Ki ± 1%
GetTimeline_InMemory/events-10-4           7.953Ki ± 0%
GetTimeline_InMemory/events-50-4           46.62Ki ± 0%
GetTimeline_InMemory/events-100-4          94.48Ki ± 0%
GetTimeline_InMemory/events-500-4          472.8Ki ± 0%
GetTimeline_InMemory/events-1000-4         944.3Ki ± 0%
GetTimeline_SQLite/events-10-4             16.74Ki ± 0%
GetTimeline_SQLite/events-50-4             87.14Ki ± 0%
GetTimeline_SQLite/events-100-4            175.4Ki ± 0%
GetTimeline_SQLite/events-500-4            846.1Ki ± 0%
GetTimeline_SQLite/events-1000-4           1.639Mi ± 0%
geomean                                    67.21Ki

                                   │ baseline-bench.txt │
                                   │     allocs/op      │
EventStoreAppend_InMemory-4                  7.000 ± 0%
EventStoreAppend_SQLite-4                    53.00 ± 0%
GetTimeline_InMemory/events-10-4             125.0 ± 0%
GetTimeline_InMemory/events-50-4             653.0 ± 0%
GetTimeline_InMemory/events-100-4           1.306k ± 0%
GetTimeline_InMemory/events-500-4           6.514k ± 0%
GetTimeline_InMemory/events-1000-4          13.02k ± 0%
GetTimeline_SQLite/events-10-4               382.0 ± 0%
GetTimeline_SQLite/events-50-4              1.852k ± 0%
GetTimeline_SQLite/events-100-4             3.681k ± 0%
GetTimeline_SQLite/events-500-4             18.54k ± 0%
GetTimeline_SQLite/events-1000-4            37.29k ± 0%
geomean                                     1.162k

cpu: AMD EPYC 9V74 80-Core Processor                
                                   │ benchmark-results.txt │
                                   │        sec/op         │
EventStoreAppend_InMemory-4                   1.067µ ± 13%
EventStoreAppend_SQLite-4                     1.081m ±  5%
GetTimeline_InMemory/events-10-4              13.51µ ±  2%
GetTimeline_InMemory/events-50-4              73.09µ ±  5%
GetTimeline_InMemory/events-100-4             114.8µ ± 25%
GetTimeline_InMemory/events-500-4             569.6µ ±  1%
GetTimeline_InMemory/events-1000-4            1.156m ±  1%
GetTimeline_SQLite/events-10-4                57.43µ ±  1%
GetTimeline_SQLite/events-50-4                189.6µ ±  1%
GetTimeline_SQLite/events-100-4               353.9µ ±  1%
GetTimeline_SQLite/events-500-4               1.637m ±  0%
GetTimeline_SQLite/events-1000-4              3.211m ±  0%
geomean                                       186.3µ

                                   │ benchmark-results.txt │
                                   │         B/op          │
EventStoreAppend_InMemory-4                    756.5 ± 12%
EventStoreAppend_SQLite-4                    1.983Ki ±  2%
GetTimeline_InMemory/events-10-4             7.953Ki ±  0%
GetTimeline_InMemory/events-50-4             46.62Ki ±  0%
GetTimeline_InMemory/events-100-4            94.48Ki ±  0%
GetTimeline_InMemory/events-500-4            472.8Ki ±  0%
GetTimeline_InMemory/events-1000-4           944.3Ki ±  0%
GetTimeline_SQLite/events-10-4               16.74Ki ±  0%
GetTimeline_SQLite/events-50-4               87.14Ki ±  0%
GetTimeline_SQLite/events-100-4              175.4Ki ±  0%
GetTimeline_SQLite/events-500-4              846.1Ki ±  0%
GetTimeline_SQLite/events-1000-4             1.639Mi ±  0%
geomean                                      67.10Ki

                                   │ benchmark-results.txt │
                                   │       allocs/op       │
EventStoreAppend_InMemory-4                     7.000 ± 0%
EventStoreAppend_SQLite-4                       53.00 ± 0%
GetTimeline_InMemory/events-10-4                125.0 ± 0%
GetTimeline_InMemory/events-50-4                653.0 ± 0%
GetTimeline_InMemory/events-100-4              1.306k ± 0%
GetTimeline_InMemory/events-500-4              6.514k ± 0%
GetTimeline_InMemory/events-1000-4             13.02k ± 0%
GetTimeline_SQLite/events-10-4                  382.0 ± 0%
GetTimeline_SQLite/events-50-4                 1.852k ± 0%
GetTimeline_SQLite/events-100-4                3.681k ± 0%
GetTimeline_SQLite/events-500-4                18.54k ± 0%
GetTimeline_SQLite/events-1000-4               37.29k ± 0%
geomean                                        1.162k

Benchmarks run with go test -bench=. -benchmem -count=6.
Regressions ≥ 20% are flagged. Results compared via benchstat.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants