Skip to content

docs(mcp): retrospective + scope-lock complete for #856#858

Merged
intel352 merged 1 commit into
mainfrom
chore/mcp-metadata-retro
Jun 5, 2026
Merged

docs(mcp): retrospective + scope-lock complete for #856#858
intel352 merged 1 commit into
mainfrom
chore/mcp-metadata-retro

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 5, 2026

Post-merge closeout for #856 (MCP tool metadata accuracy). Retro + plan Status Locked->Complete (removes the .scope-lock sidecar). Docs-only.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 5, 2026 03:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Closes out the documentation process for MCP tool metadata accuracy work (post-merge retrospective + marking the plan complete), including removing the plan’s .scope-lock sidecar.

Changes:

  • Added a retrospective documenting what shipped, what gates caught, lessons learned, and follow-ups for #856.
  • Removed the scope-lock sidecar file now that the plan is marked complete.
  • Updated the implementation plan status from Locked to Complete with a completion timestamp.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/retros/2026-06-04-mcp-tool-metadata-accuracy.md Adds the post-merge retrospective for #856 (what shipped, gates, lessons, follow-ups).
docs/plans/2026-06-04-mcp-tool-metadata-accuracy.md.scope-lock Removes the scope-lock sidecar as part of status closeout.
docs/plans/2026-06-04-mcp-tool-metadata-accuracy.md Updates the plan status line to Complete with timestamp.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

⏱ Benchmark Results

No significant performance regressions detected.

benchstat comparison (baseline → PR)
## benchstat: baseline → PR
baseline-bench.txt:304: parsing iteration count: invalid syntax
baseline-bench.txt:290291: parsing iteration count: invalid syntax
baseline-bench.txt:604449: parsing iteration count: invalid syntax
baseline-bench.txt:918829: parsing iteration count: invalid syntax
baseline-bench.txt:1231073: parsing iteration count: invalid syntax
baseline-bench.txt:1572489: parsing iteration count: invalid syntax
benchmark-results.txt:304: parsing iteration count: invalid syntax
benchmark-results.txt:274385: parsing iteration count: invalid syntax
benchmark-results.txt:542886: parsing iteration count: invalid syntax
benchmark-results.txt:810004: parsing iteration count: invalid syntax
benchmark-results.txt:1109576: parsing iteration count: invalid syntax
benchmark-results.txt:1650153: parsing iteration count: invalid syntax
goos: linux
goarch: amd64
pkg: github.com/GoCodeAlone/workflow/dynamic
cpu: AMD EPYC 7763 64-Core Processor                
                            │ baseline-bench.txt │       benchmark-results.txt        │
                            │       sec/op       │    sec/op     vs base              │
InterpreterCreation-4               7.849m ± 60%   6.355m ± 69%       ~ (p=0.699 n=6)
ComponentLoad-4                     3.546m ±  2%   3.615m ±  7%  +1.95% (p=0.041 n=6)
ComponentExecute-4                  1.901µ ±  0%   1.964µ ±  1%  +3.29% (p=0.002 n=6)
PoolContention/workers-1-4          1.071µ ±  2%   1.097µ ±  3%  +2.38% (p=0.015 n=6)
PoolContention/workers-2-4          1.067µ ±  1%   1.086µ ±  3%  +1.73% (p=0.004 n=6)
PoolContention/workers-4-4          1.075µ ±  4%   1.084µ ±  3%       ~ (p=0.180 n=6)
PoolContention/workers-8-4          1.072µ ±  1%   1.096µ ±  1%  +2.24% (p=0.002 n=6)
PoolContention/workers-16-4         1.077µ ±  8%   1.086µ ±  2%       ~ (p=0.058 n=6)
ComponentLifecycle-4                3.564m ±  3%   3.619m ±  1%       ~ (p=0.065 n=6)
SourceValidation-4                  2.277µ ±  1%   2.343µ ±  1%  +2.90% (p=0.002 n=6)
RegistryConcurrent-4                815.4n ±  2%   802.9n ±  3%       ~ (p=0.394 n=6)
LoaderLoadFromString-4              3.585m ±  1%   3.619m ±  1%  +0.96% (p=0.026 n=6)
geomean                             18.66µ         18.59µ        -0.35%

                            │ baseline-bench.txt │        benchmark-results.txt         │
                            │        B/op        │     B/op      vs base                │
InterpreterCreation-4               2.027Mi ± 0%   2.027Mi ± 0%       ~ (p=0.617 n=6)
ComponentLoad-4                     2.180Mi ± 0%   2.180Mi ± 0%       ~ (p=0.100 n=6)
ComponentExecute-4                  1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-1-4          1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-2-4          1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-4-4          1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-8-4          1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-16-4         1.203Ki ± 0%   1.203Ki ± 0%       ~ (p=1.000 n=6) ¹
ComponentLifecycle-4                2.183Mi ± 0%   2.183Mi ± 0%       ~ (p=0.721 n=6)
SourceValidation-4                  1.984Ki ± 0%   1.984Ki ± 0%       ~ (p=1.000 n=6) ¹
RegistryConcurrent-4                1.133Ki ± 0%   1.133Ki ± 0%       ~ (p=1.000 n=6) ¹
LoaderLoadFromString-4              2.182Mi ± 0%   2.182Mi ± 0%       ~ (p=0.816 n=6)
geomean                             15.25Ki        15.25Ki       -0.00%
¹ all samples are equal

                            │ baseline-bench.txt │        benchmark-results.txt        │
                            │     allocs/op      │  allocs/op   vs base                │
InterpreterCreation-4                15.68k ± 0%   15.68k ± 0%       ~ (p=1.000 n=6)
ComponentLoad-4                      18.02k ± 0%   18.02k ± 0%       ~ (p=1.000 n=6)
ComponentExecute-4                    25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-1-4            25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-2-4            25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-4-4            25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-8-4            25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
PoolContention/workers-16-4           25.00 ± 0%    25.00 ± 0%       ~ (p=1.000 n=6) ¹
ComponentLifecycle-4                 18.07k ± 0%   18.07k ± 0%       ~ (p=1.000 n=6) ¹
SourceValidation-4                    32.00 ± 0%    32.00 ± 0%       ~ (p=1.000 n=6) ¹
RegistryConcurrent-4                  2.000 ± 0%    2.000 ± 0%       ~ (p=1.000 n=6) ¹
LoaderLoadFromString-4               18.06k ± 0%   18.06k ± 0%       ~ (p=1.000 n=6) ¹
geomean                               183.3         183.3       +0.00%
¹ all samples are equal

pkg: github.com/GoCodeAlone/workflow/middleware
                                  │ baseline-bench.txt │       benchmark-results.txt       │
                                  │       sec/op       │   sec/op     vs base              │
CircuitBreakerDetection-4                 285.4n ± 13%   287.4n ± 2%       ~ (p=0.394 n=6)
CircuitBreakerExecution_Success-4         21.43n ±  0%   21.45n ± 0%       ~ (p=0.119 n=6)
CircuitBreakerExecution_Failure-4         66.58n ±  0%   65.39n ± 0%  -1.78% (p=0.002 n=6)
geomean                                   74.12n         73.87n       -0.33%

                                  │ baseline-bench.txt │       benchmark-results.txt        │
                                  │        B/op        │    B/op     vs base                │
CircuitBreakerDetection-4                 144.0 ± 0%     144.0 ± 0%       ~ (p=1.000 n=6) ¹
CircuitBreakerExecution_Success-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
CircuitBreakerExecution_Failure-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                              ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                  │ baseline-bench.txt │       benchmark-results.txt        │
                                  │     allocs/op      │ allocs/op   vs base                │
CircuitBreakerDetection-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
CircuitBreakerExecution_Success-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
CircuitBreakerExecution_Failure-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                              ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/module
                                 │ baseline-bench.txt │        benchmark-results.txt        │
                                 │       sec/op       │    sec/op     vs base               │
IaCStateBackend_InProcess-4              319.3n ± 37%   322.1n ±  1%        ~ (p=0.370 n=6)
IaCStateBackend_GRPC-4                   9.486m ±  3%   9.478m ± 19%        ~ (p=0.485 n=6)
JQTransform_Simple-4                     664.0n ± 37%   686.0n ± 48%        ~ (p=0.394 n=6)
JQTransform_ObjectConstruction-4         1.502µ ±  1%   1.743µ ±  0%  +16.01% (p=0.002 n=6)
JQTransform_ArraySelect-4                3.428µ ±  3%   3.673µ ±  1%   +7.13% (p=0.002 n=6)
JQTransform_Complex-4                    39.97µ ±  1%   41.37µ ±  1%   +3.50% (p=0.002 n=6)
JQTransform_Throughput-4                 1.832µ ±  1%   2.075µ ±  1%  +13.27% (p=0.002 n=6)
SSEPublishDelivery-4                     64.73n ±  1%   65.04n ±  0%        ~ (p=0.058 n=6)
geomean                                  3.858µ         4.067µ         +5.41%

                                 │ baseline-bench.txt │         benchmark-results.txt         │
                                 │        B/op        │     B/op       vs base                │
IaCStateBackend_InProcess-4             416.0 ±  0%       416.0 ±  0%       ~ (p=1.000 n=6) ¹
IaCStateBackend_GRPC-4                5.763Mi ± 11%     5.996Mi ± 10%       ~ (p=0.310 n=6)
JQTransform_Simple-4                  1.273Ki ±  0%     1.273Ki ±  0%       ~ (p=1.000 n=6) ¹
JQTransform_ObjectConstruction-4      1.773Ki ±  0%     1.773Ki ±  0%       ~ (p=1.000 n=6) ¹
JQTransform_ArraySelect-4             2.625Ki ±  0%     2.625Ki ±  0%       ~ (p=1.000 n=6) ¹
JQTransform_Complex-4                 16.31Ki ±  0%     16.31Ki ±  0%       ~ (p=1.000 n=6) ¹
JQTransform_Throughput-4              1.984Ki ±  0%     1.984Ki ±  0%       ~ (p=1.000 n=6) ¹
SSEPublishDelivery-4                    0.000 ±  0%       0.000 ±  0%       ~ (p=1.000 n=6) ¹
geomean                                             ²                  +0.50%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                 │ baseline-bench.txt │        benchmark-results.txt        │
                                 │     allocs/op      │  allocs/op   vs base                │
IaCStateBackend_InProcess-4              2.000 ± 0%      2.000 ± 0%       ~ (p=1.000 n=6) ¹
IaCStateBackend_GRPC-4                  6.839k ± 0%     6.837k ± 0%       ~ (p=0.916 n=6)
JQTransform_Simple-4                     10.00 ± 0%      10.00 ± 0%       ~ (p=1.000 n=6) ¹
JQTransform_ObjectConstruction-4         15.00 ± 0%      15.00 ± 0%       ~ (p=1.000 n=6) ¹
JQTransform_ArraySelect-4                30.00 ± 0%      30.00 ± 0%       ~ (p=1.000 n=6) ¹
JQTransform_Complex-4                    328.0 ± 0%      328.0 ± 0%       ~ (p=1.000 n=6) ¹
JQTransform_Throughput-4                 17.00 ± 0%      17.00 ± 0%       ~ (p=1.000 n=6) ¹
SSEPublishDelivery-4                     0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                             ²                -0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/schema
                                    │ baseline-bench.txt │       benchmark-results.txt       │
                                    │       sec/op       │   sec/op     vs base              │
SchemaValidation_Simple-4                    1.111µ ± 5%   1.133µ ± 3%       ~ (p=0.394 n=6)
SchemaValidation_AllFields-4                 1.658µ ± 7%   1.674µ ± 5%       ~ (p=0.485 n=6)
SchemaValidation_FormatValidation-4          1.583µ ± 4%   1.602µ ± 2%       ~ (p=1.000 n=6)
SchemaValidation_ManySchemas-4               1.819µ ± 3%   1.805µ ± 2%       ~ (p=0.221 n=6)
geomean                                      1.517µ        1.530µ       +0.85%

                                    │ baseline-bench.txt │       benchmark-results.txt        │
                                    │        B/op        │    B/op     vs base                │
SchemaValidation_Simple-4                   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_AllFields-4                0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_FormatValidation-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_ManySchemas-4              0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                    │ baseline-bench.txt │       benchmark-results.txt        │
                                    │     allocs/op      │ allocs/op   vs base                │
SchemaValidation_Simple-4                   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_AllFields-4                0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_FormatValidation-4         0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
SchemaValidation_ManySchemas-4              0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/GoCodeAlone/workflow/store
                                   │ baseline-bench.txt │        benchmark-results.txt        │
                                   │       sec/op       │    sec/op     vs base               │
EventStoreAppend_InMemory-4                1.212µ ± 24%   1.347µ ± 14%        ~ (p=0.394 n=6)
EventStoreAppend_SQLite-4                  1.922m ± 12%   1.425m ±  7%  -25.82% (p=0.002 n=6)
GetTimeline_InMemory/events-10-4           13.92µ ±  5%   14.66µ ±  3%   +5.34% (p=0.002 n=6)
GetTimeline_InMemory/events-50-4           76.49µ ±  3%   81.78µ ±  1%   +6.92% (p=0.002 n=6)
GetTimeline_InMemory/events-100-4          122.0µ ± 32%   162.5µ ± 21%  +33.20% (p=0.009 n=6)
GetTimeline_InMemory/events-500-4          623.1µ ±  1%   660.2µ ±  0%   +5.95% (p=0.002 n=6)
GetTimeline_InMemory/events-1000-4         1.273m ±  1%   1.346m ±  1%   +5.73% (p=0.002 n=6)
GetTimeline_SQLite/events-10-4             70.72µ ±  0%   73.14µ ±  0%   +3.43% (p=0.002 n=6)
GetTimeline_SQLite/events-50-4             213.9µ ±  1%   220.6µ ±  2%   +3.13% (p=0.002 n=6)
GetTimeline_SQLite/events-100-4            387.7µ ±  1%   401.7µ ±  1%   +3.61% (p=0.002 n=6)
GetTimeline_SQLite/events-500-4            1.768m ±  1%   1.834m ±  2%   +3.74% (p=0.002 n=6)
GetTimeline_SQLite/events-1000-4           3.489m ±  0%   3.612m ±  2%   +3.52% (p=0.002 n=6)
geomean                                    212.9µ         221.9µ         +4.23%

                                   │ baseline-bench.txt │        benchmark-results.txt         │
                                   │        B/op        │     B/op      vs base                │
EventStoreAppend_InMemory-4                  802.0 ± 5%     781.5 ± 9%       ~ (p=0.589 n=6)
EventStoreAppend_SQLite-4                  1.981Ki ± 4%   1.984Ki ± 2%       ~ (p=0.327 n=6)
GetTimeline_InMemory/events-10-4           7.953Ki ± 0%   7.953Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-50-4           46.62Ki ± 0%   46.62Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-100-4          94.48Ki ± 0%   94.48Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-500-4          472.8Ki ± 0%   472.8Ki ± 0%       ~ (p=1.000 n=6)
GetTimeline_InMemory/events-1000-4         944.3Ki ± 0%   944.3Ki ± 0%  -0.00% (p=0.004 n=6)
GetTimeline_SQLite/events-10-4             16.74Ki ± 0%   16.74Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-50-4             87.14Ki ± 0%   87.14Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-100-4            175.4Ki ± 0%   175.4Ki ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-500-4            846.1Ki ± 0%   846.1Ki ± 0%  +0.00% (p=0.002 n=6)
GetTimeline_SQLite/events-1000-4           1.639Mi ± 0%   1.639Mi ± 0%       ~ (p=0.177 n=6)
geomean                                    67.42Ki        67.28Ki       -0.20%
¹ all samples are equal

                                   │ baseline-bench.txt │        benchmark-results.txt        │
                                   │     allocs/op      │  allocs/op   vs base                │
EventStoreAppend_InMemory-4                  7.000 ± 0%    7.000 ± 0%       ~ (p=1.000 n=6) ¹
EventStoreAppend_SQLite-4                    53.00 ± 0%    53.00 ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-10-4             125.0 ± 0%    125.0 ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-50-4             653.0 ± 0%    653.0 ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-100-4           1.306k ± 0%   1.306k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-500-4           6.514k ± 0%   6.514k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_InMemory/events-1000-4          13.02k ± 0%   13.02k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-10-4               382.0 ± 0%    382.0 ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-50-4              1.852k ± 0%   1.852k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-100-4             3.681k ± 0%   3.681k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-500-4             18.54k ± 0%   18.54k ± 0%       ~ (p=1.000 n=6) ¹
GetTimeline_SQLite/events-1000-4            37.29k ± 0%   37.29k ± 0%       ~ (p=1.000 n=6) ¹
geomean                                     1.162k        1.162k       +0.00%
¹ all samples are equal

Benchmarks run with go test -bench=. -benchmem -count=6.
Regressions ≥ 20% are flagged. Results compared via benchstat.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@intel352 intel352 merged commit fd9dbaa into main Jun 5, 2026
23 checks passed
@intel352 intel352 deleted the chore/mcp-metadata-retro branch June 5, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants