fix(wfctl): preserve registry download checksums#853
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances wfctl plugin registry-sync to optionally read checksums.txt from GitHub releases and, when available, include sha256 values in generated downloads entries in registry manifests—improving downstream install integrity verification while remaining compatible with plugins that don’t publish checksums.
Changes:
- Extend release asset metadata to include an optional
sha256field and plumb it into manifestdownloadsentries during--fix. - Add support code to download and parse
checksums.txtfrom a release (best-effort / optional). - Add unit tests for parsing release checksums and for emitting
sha256inapplyFixoutput.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cmd/wfctl/plugin_registry_sync.go | Adds sha256 support to release downloads and introduces checksums.txt download + parsing for registry-sync. |
| cmd/wfctl/plugin_registry_sync_test.go | Adds tests covering checksums parsing and ensuring applyFix writes sha256 when provided. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification