fix(wfctl): sync versioned registry release assets#852
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wfctl’s plugin registry sync to better align registry manifests with upstream plugin release conventions and metadata, particularly for IaC plugins.
Changes:
- Parse GitHub release assets that encode versions using underscore-separated names (e.g.
workflow-plugin-gcp_2.3.0_linux_amd64.tar.gz). - Refactor plugin.json → registry manifest metadata syncing into a helper and project
plugin.json.iacServicesinto registry capabilities. - Add regression tests covering the new release-asset parsing and IaC services metadata projection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/wfctl/plugin_registry_sync.go | Adds versioned-asset platform parsing and refactors/extends registry manifest metadata sync from upstream plugin.json. |
| cmd/wfctl/plugin_registry_sync_test.go | Adds tests for release asset platform parsing and IaC services projection into manifest capabilities. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow-plugin-gcp_2.3.0_linux_amd64.tar.gzplugin.json.iacServicesinto registrycapabilities.serviceMethodsduring registry syncVerification
GOWORK=off go test ./cmd/wfctl -run 'TestPluginRegistrySync_(ReleaseAssetPlatform|MetadataSyncProjectsIaCServices|DownloadsMatchVersion|DefaultSkipsBuiltinManifests)' -count=1\n-GOWORK=off go test ./cmd/wfctl -count=1\n\nRefs Cross-cloud ephemeral IaCProviderRunner (RunJob): optional gRPC service + per-cloud impls #840