fix(secrets): reflect.Pointer not reflect.Ptr (forward-fix main Lint)#844
Merged
Conversation
…v2.12.0) golangci-lint v2.12.0 (CI) govet flags 'Constant reflect.Ptr should be inlined' for the deprecated reflect.Ptr alias added in #843. Use the canonical reflect.Pointer. (Local golangci v2.11.4 did not flag this — version gap; main CI Lint went red on the #843 merge.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR forward-fixes a CI lint failure by updating the typed-nil detection in secrets to use the canonical reflect.Pointer kind constant instead of the deprecated reflect.Ptr alias, aligning with newer govet/golangci-lint behavior.
Changes:
- Replace
reflect.Ptrwithreflect.PointerinisNilProviderto satisfygovet(“Constant reflect.Ptr should be inlined”). - Keep nil-kind handling behavior unchanged while removing the lint regression on main.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-fix: main CI Lint went red after #843 — golangci-lint v2.12.0 govet flags the deprecated
reflect.Ptralias (secrets/reachability.go:146) with "Constant reflect.Ptr should be inlined". Replaces it with the canonicalreflect.Pointer. Local golangci v2.11.4 did not flag this (version gap). Verified:go vet ./secrets/clean, build + secrets tests pass.🤖 Generated with Claude Code