fix: keep registry sync from mutating builtins#835
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a registry sync bug where the default release-asset sync was mutating built-in/core manifests (originally surfaced by PR #190). The default sync now skips manifests whose type is builtin/core, and the core sync path detects and (with --fix) removes stray downloads entries that don't belong on built-in manifests.
Changes:
- Default
syncDefaultskips manifests with typebuiltinorcorevia newisCoreRegistryManifestTypehelper. syncCorePluginManifestsnow treats presence of adownloadskey as drift and emits a clarifying message;writeCoreManifestalready strips it on--fix.- Adds two regression tests covering both behaviors (default skip and downloads-only drift).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/wfctl/plugin_registry_sync.go | Skip builtin/core manifests in default release-asset sync; updated header comment numbering. |
| cmd/wfctl/plugin_registry_sync_core.go | Detect downloads field as drift on core manifests with a dedicated drift message. |
| cmd/wfctl/plugin_registry_sync_test.go | Adds regression tests for builtin skip and downloads-only drift detection/fix. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification